Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt documentation of kostal plenticore to match changes in core. #29811

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

stegm
Copy link
Contributor

@stegm stegm commented Nov 12, 2023

Proposed change

PR home-assistant/core#103802 introduces some new sensors from the underlying library. These sensors are important for the energy dashboard. This PR adds the sensors to the documentation and also shows how to configure the energy dashboard with the integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Nov 12, 2023
@stegm stegm marked this pull request as ready for review November 12, 2023 20:44
@edenhaus edenhaus added the parent-merged The parent PR has been merged already label Nov 29, 2023
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
source/_integrations/kostal_plenticore.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stegm 👍

@c0ffeeca7 c0ffeeca7 merged commit 92fcec1 into home-assistant:next Nov 29, 2023
5 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Nov 29, 2023
@stegm stegm deleted the kostal_plenticore_sensors branch November 29, 2023 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants