-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sensors of Kostal Plenticore integration #103802
Merged
edenhaus
merged 7 commits into
home-assistant:dev
from
stegm:kostal_plenticore_pykoplenti_update
Nov 29, 2023
Merged
Add new sensors of Kostal Plenticore integration #103802
edenhaus
merged 7 commits into
home-assistant:dev
from
stegm:kostal_plenticore_pykoplenti_update
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
stegm
force-pushed
the
kostal_plenticore_pykoplenti_update
branch
2 times, most recently
from
November 12, 2023 19:35
0aed859
to
80f4ba4
Compare
stegm
force-pushed
the
kostal_plenticore_pykoplenti_update
branch
2 times, most recently
from
November 13, 2023 19:48
2f77c2b
to
80f8737
Compare
stegm
force-pushed
the
kostal_plenticore_pykoplenti_update
branch
from
November 14, 2023 18:42
80f8737
to
ccd97c2
Compare
jpbede
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks 👍
frenck
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Nov 27, 2023
edenhaus
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stegm 👍
For the future, please split the dependency bump and adding new entities/features into two different PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
integration: kostal_plenticore
new-feature
Quality Scale: No score
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR updates the underlying
pykoplenti
library to a newer version with more sensors. Some of them are important to make the integration more usable for the Energy Dashboard (namely Energy to Grid). Please see also the PR of the documentation for this matter: home-assistant/home-assistant.io#29811.The changes in the tests are mainly due to the fact that the model in the
pykoplenti
library now uses pydantic-based classes and the tests need to be adapted accordingly.Changelog of pykoplenti
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: