Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sensors of Kostal Plenticore integration #103802

Merged

Conversation

stegm
Copy link
Contributor

@stegm stegm commented Nov 11, 2023

Breaking change

Proposed change

This PR updates the underlying pykoplenti library to a newer version with more sensors. Some of them are important to make the integration more usable for the Energy Dashboard (namely Energy to Grid). Please see also the PR of the documentation for this matter: home-assistant/home-assistant.io#29811.

The changes in the tests are mainly due to the fact that the model in the pykoplenti library now uses pydantic-based classes and the tests need to be adapted accordingly.

Changelog of pykoplenti

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@stegm stegm force-pushed the kostal_plenticore_pykoplenti_update branch from 80f8737 to ccd97c2 Compare November 14, 2023 18:42
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks 👍

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 27, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stegm 👍

For the future, please split the dependency bump and adding new entities/features into two different PRs.

@edenhaus edenhaus merged commit 09d7679 into home-assistant:dev Nov 29, 2023
52 checks passed
@stegm stegm deleted the kostal_plenticore_pykoplenti_update branch November 29, 2023 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants