Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyroon to 0.1.4 #89124

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Bump pyroon to 0.1.4 #89124

merged 1 commit into from
Mar 5, 2023

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Mar 3, 2023

Proposed change

This PR updates the pyroon library used to interface to the roon media player.

It contains two bug fixes for play_media. One that causes an exception when trying to play to an inactive player (which HA caught anyway) - the other a work-round to a roon api bug when trying to play a genre. These were not raised as HA issues.

It also contains extra logic to support playlist repeat modes - this library update is required for #88851

The library includes support for an extra roon volume control service - which is not used (or called) by home assistant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The library changes are here: pavoni/pyroon@0.1.3...0.1.4

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 4, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pavoni 👍

../Frenck

@frenck frenck merged commit 08b3945 into dev Mar 5, 2023
@frenck frenck deleted the update_pyroon branch March 5, 2023 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed dependency integration: roon Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants