Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat to roon media player #88851

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Add repeat to roon media player #88851

merged 3 commits into from
Mar 5, 2023

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Feb 27, 2023

Proposed change

This PR adds repeat to the roon media player. It requires a new version of the pyroon library to support this, which is in this PR #89124 (which should be merged first)

It also fixes a bug in the set_volume_level method that was incorrectly casting a float to an integer. The roon api takes a float anyway - and the cast was incorrectly truncating values.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Add repeat to roon media player. Add repeat to roon media player Feb 27, 2023
@pavoni pavoni force-pushed the update_roon_repeat branch from c8d2796 to f4cee92 Compare February 27, 2023 19:24
@pavoni pavoni mentioned this pull request Mar 3, 2023
19 tasks
@epenet epenet marked this pull request as draft March 4, 2023 00:10
@frenck
Copy link
Member

frenck commented Mar 5, 2023

#89124 has been merged, this PR can be rebased and marked ready for review I guess?

../Frenck

@pavoni pavoni marked this pull request as ready for review March 5, 2023 14:33
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @pavoni 👍

../Frenck

@frenck frenck merged commit 7b54061 into dev Mar 5, 2023
@frenck frenck deleted the update_roon_repeat branch March 5, 2023 14:43
@pavoni
Copy link
Contributor Author

pavoni commented Mar 5, 2023

Thanks for the help everyone.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants