-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reauthentication support for LIVISI integration #86717
Add reauthentication support for LIVISI integration #86717
Conversation
Draft until #86721 is merged |
9fb1c6a
to
ac2e002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure 100% coverage on the config flow.
ac2e002
to
acc631f
Compare
Hello @epenet , I have an error when I try to commit my changes:
Did you see this message before? |
No I have not seen this. It looks like something is wrong on your development environment. |
2a01292
to
58408d8
Compare
Thank you for your suggestion. I rebuilt my environment and now the problem is solved. |
The code coverage for the config_flow.py is now 100%. |
@epenet can you please take a look again at this pull request? |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
76dfde0
to
72be0d5
Compare
72be0d5
to
976bae4
Compare
9f277e3
to
3c6be1a
Compare
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
For me, the issue still appears: I reported the issue StefanIacobLivisi/aiolivisi#11. |
Any chance that this CLA thing gets resolved? I have no idea on its meaning, but can I (as a normal user) somehow support? @epenet: Can you give a quick remark? Thanks. |
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
CLA issue has to be resolved by the PR authors. |
It is so sad that the fix is there, but @StefanIacobLivisi, @StefanIacob29 does not find the time to sign the CLA since weeks. Please, we need a working solution here. Otherwise, the binding is useless as it looses connection after two days... |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
Add reauthentication support in LIVISI integration.
Type of change
Additional information
aiolivisi: https://github.com/StefanIacobLivisi/aiolivisi
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: