Livisi integration never recovers from a sever disconnect

[dhauwer]

The problem

The Livisi integration disconnects from the server every x days and never recovers the connection untill reloading the integration.

What version of Home Assistant Core has the issue?

2022.12.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Livisi

Link to integration documentation on our website

https://www.home-assistant.io/integrations/livisi/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2022-12-22 11:47:02.215 DEBUG (MainThread) [homeassistant.components.livisi] Finished fetching Livisi devices data in 1.077 seconds (success: True)
2022-12-22 11:48:02.265 ERROR (MainThread) [homeassistant.components.livisi] Error requesting Livisi devices data: Server disconnected
2022-12-22 11:48:02.267 DEBUG (MainThread) [homeassistant.components.livisi] Finished fetching Livisi devices data in 0.128 seconds (success: False)
2022-12-22 11:49:02.139 ERROR (MainThread) [homeassistant.components.livisi] Unexpected error fetching Livisi devices data: 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 225, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/components/livisi/coordinator.py", line 56, in _async_update_data
    return await self.async_get_devices()
  File "/usr/src/homeassistant/homeassistant/components/livisi/coordinator.py", line 83, in async_get_devices
    return await self.aiolivisi.async_get_devices()
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 142, in async_get_devices
    devices = await self.async_send_authorized_request("get", url="device")
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 71, in async_send_authorized_request
    ip_address = self._livisi_connection_data["ip_address"]
TypeError: 'NoneType' object is not subscriptable

Additional information

No response

[home-assistant]

Hey there @StefanIacobLivisi, mind taking a look at this issue as it has been labeled with an integration (livisi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of livisi can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign livisi Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

livisi documentation
livisi source
_{^{(message by IssueLinks)}}

[Tobster77]

This might be the root cause for #84687. The problem in not reaching the PSS might by simply the disconnection of the SHC.

[planbnet]

I found the real root cause for this: after 5-7 days (it sure when exactly) the auth token expires but the integration never requests a new one and silently fails.

[Tobster77]

For me, the issue still appears:
I updated HA to the most recent version 2023.4.2 (HASS on Pi3). Plays nicely for one day or two, then the SHC and all of its devices get unavailable. User experience is just like here.

I reported the issue here.

[planbnet]

This issue (identified by the logs) is definitely resolved. You seem to have another problem.

[Tobster77]

Thanks. I observed a strange behaviour: After a week, my devices reappeared again without a reboot or reload!
I am confused and placed a discussion thread as well in the community.

My logs show the following - does this give a hint to you, @planbnet ?

Logger: homeassistant.components.livisi
Source: components/livisi/coordinator.py:92
Integration: LIVISI Smart Home (documentation, issues)
First occurred: 18. April 2023 um 11:33:53 (2822 occurrences)
Last logged: 11:22:28

Unexpected error fetching Livisi devices data: string indices must be integers
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 250, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/components/livisi/coordinator.py", line 58, in _async_update_data
    return await self.async_get_devices()
  File "/usr/src/homeassistant/homeassistant/components/livisi/coordinator.py", line 92, in async_get_devices
    return await self.aiolivisi.async_get_devices()
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 164, in async_get_devices
    device_id = device["id"]
TypeError: string indices must be integers

and

Logger: homeassistant.config_entries
Source: components/livisi/coordinator.py:77
First occurred: 12. April 2023 um 09:11:56 (1 occurrences)
Last logged: 12. April 2023 um 09:11:56

Error setting up entry SHC Avatar for livisi
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 581, in write_bytes
    await self.body.write(writer)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/payload.py", line 247, in write
    await writer.write(self._value)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/http_writer.py", line 115, in write
    self._write(chunk)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/http_writer.py", line 75, in _write
    raise ConnectionResetError("Cannot write to closing transport")
ConnectionResetError: Cannot write to closing transport

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 52, in async_set_token
    access_data = await self.async_get_jwt_token(livisi_connection_data)
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 98, in async_get_jwt_token
    return await self.async_send_request(
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 112, in async_send_request
    response = await self.__async_send_request(method, url, payload, headers)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 560, in _request
    await resp.start(conn)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 899, in start
    message, payload = await protocol.read()  # type: ignore[union-attr]
  File "/usr/local/lib/python3.10/site-packages/aiohttp/streams.py", line 616, in read
    await self._waiter
aiohttp.client_exceptions.ClientOSError: [Errno None] Can not write request body for http://192.168.178.67:8080/auth/token

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/homeassistant/homeassistant/components/livisi/__init__.py", line 28, in async_setup_entry
    await coordinator.async_setup()
  File "/usr/src/homeassistant/homeassistant/components/livisi/coordinator.py", line 77, in async_setup
    await self.aiolivisi.async_set_token(
  File "/usr/local/lib/python3.10/site-packages/aiolivisi/aiolivisi.py", line 61, in async_set_token
    raise IncorrectIpAddressException from error
aiolivisi.errors.IncorrectIpAddressException

Thanks!

[planbnet]

Looks like a network connection problem from which the integration never recovers. I guess this will be fixed by #86717 but I have nothing to do with that PR and haven't heard anything about the currecnt status from livisi...