Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix haveibeenpwned user-agent string #84919

Merged
merged 4 commits into from
Jan 1, 2023
Merged

Fix haveibeenpwned user-agent string #84919

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cd42ed
Fixed user-agent string not being accepted as an valid header
ChopperRob Dec 31, 2022
0e8267e
Merge branch 'dev' into HIBP_Fix
ChopperRob Dec 31, 2022
52ed2e7
Update homeassistant/components/haveibeenpwned/sensor.py
ChopperRob Dec 31, 2022
beacb87
Removed the aiohttp import
ChopperRob Dec 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions homeassistant/components/haveibeenpwned/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from http import HTTPStatus
import logging

from aiohttp.hdrs import USER_AGENT
import requests
import voluptuous as vol

Expand Down Expand Up @@ -160,7 +159,7 @@ def update(self, **kwargs):
"""Get the latest data for current email from REST service."""
try:
url = f"{URL}{self._email}?truncateResponse=false"
header = {USER_AGENT: HA_USER_AGENT, "hibp-api-key": self._api_key}
header = {"User-Agent": HA_USER_AGENT, "hibp-api-key": self._api_key}
_LOGGER.debug("Checking for breaches for email: %s", self._email)
req = requests.get(url, headers=header, allow_redirects=True, timeout=5)

Expand Down