Fix haveibeenpwned user-agent string #84919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: haveibeenpwned
small-pr
MartinHjelmare
changed the title
MartinHjelmare
requested changes
Dec 31, 2022
|
Note that this integration still needs a 3rd party library for the interface code to the service, but we're going to accept this small fix. Larger changes will need a 3rd party library first. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
|
I updated the branch as suggested. |
jmwhite5
approved these changes
Dec 31, 2022
khoih-prog
pushed a commit
to khoih-prog/HomeAssistant_core
that referenced
this pull request
Jan 1, 2023
* Fixed user-agent string not being accepted as an valid header * Update homeassistant/components/haveibeenpwned/sensor.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Removed the aiohttp import Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
balloob
pushed a commit
that referenced
this pull request
Jan 2, 2023
* Fixed user-agent string not being accepted as an valid header * Update homeassistant/components/haveibeenpwned/sensor.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Removed the aiohttp import Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The HaveIBeenComponent was broken because the requests library does no longer allow an istr in a header, only a str.
The user-agent header is now first converted to a str which fixes the issue
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: