Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_registry_enabled_default and missing EntityCategories in Plugwise #80629

Merged
merged 18 commits into from
Oct 21, 2022
Merged

Add entity_registry_enabled_default and missing EntityCategories in Plugwise #80629

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
29c2b10
Entity_registry_enabled_default for binary_sensors
bouwew Oct 19, 2022
b317f8d
Entity_registry_enabled_default for switches
bouwew Oct 19, 2022
bf3f008
Remove unneeded _attr_entity_registry_enabled_default
bouwew Oct 19, 2022
c362000
Add missing sensors, add enabled_default
bouwew Oct 19, 2022
afb3bb9
Add entity_category for sensors
bouwew Oct 19, 2022
3a07ccb
Update tests for disabled_default
bouwew Oct 19, 2022
c5dd373
Clean up test
bouwew Oct 19, 2022
f006dab
Correct testing disapbled sensor
bouwew Oct 19, 2022
823bb4b
Cleanup
bouwew Oct 19, 2022
6026e86
Add missing state_class
bouwew Oct 19, 2022
c667191
Remove default-disabled
bouwew Oct 20, 2022
1bf046d
Remove default-disabled
bouwew Oct 20, 2022
f37135a
Remove most default-disabled as discussed
bouwew Oct 20, 2022
36e1aa6
Revert "Correct testing disapbled sensor"
bouwew Oct 20, 2022
be8289f
Revert "Clean up test"
bouwew Oct 20, 2022
a3700f9
Revert "Update tests for disabled_default"
bouwew Oct 20, 2022
2c6fb0a
Add missing binary_sensor compressor_state
bouwew Oct 21, 2022
466daeb
Also default-disable energy_produced_interval
bouwew Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing sensors, add enabled_default
  • Loading branch information
@bouwew
bouwew committed Oct 21, 2022
commit c3620006a50a5de34177a5c71045176c8155d3ff
19 changes: 19 additions & 0 deletions homeassistant/components/plugwise/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,21 @@
native_unit_of_measurement=TEMP_CELSIUS,
device_class=SensorDeviceClass.TEMPERATURE,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
),
SensorEntityDescription(
key="setpoint_high",
name="Cooling setpoint",
device_class=SensorDeviceClass.TEMPERATURE,
native_unit_of_measurement=TEMP_CELSIUS,
entity_registry_enabled_default=False,
),
SensorEntityDescription(
key="setpoint_low",
name="Heating setpoint",
device_class=SensorDeviceClass.TEMPERATURE,
native_unit_of_measurement=TEMP_CELSIUS,
entity_registry_enabled_default=False,
),
SensorEntityDescription(
key="temperature",
Expand All @@ -52,6 +67,7 @@
native_unit_of_measurement=TEMP_CELSIUS,
device_class=SensorDeviceClass.TEMPERATURE,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
),
SensorEntityDescription(
key="outdoor_temperature",
Expand Down Expand Up @@ -94,13 +110,15 @@
native_unit_of_measurement=POWER_WATT,
device_class=SensorDeviceClass.POWER,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
frenck marked this conversation as resolved.
Show resolved Hide resolved
),
SensorEntityDescription(
key="electricity_consumed_interval",
name="Electricity consumed interval",
native_unit_of_measurement=ENERGY_WATT_HOUR,
device_class=SensorDeviceClass.ENERGY,
state_class=SensorStateClass.TOTAL,
entity_registry_enabled_default=False,
bouwew marked this conversation as resolved.
Show resolved Hide resolved
),
SensorEntityDescription(
key="electricity_consumed_peak_interval",
Expand Down Expand Up @@ -313,6 +331,7 @@ def __init__(
"""Initialise the sensor."""
super().__init__(coordinator, device_id)
self.entity_description = description

self._attr_unique_id = f"{device_id}-{description.key}"

@property
Expand Down