Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_registry_enabled_default and missing EntityCategories in Plugwise #80629

Merged
merged 18 commits into from
Oct 21, 2022

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 19, 2022

Proposed change

All changes:

  • Implement entity_registry_enabled_default, add missing EntityCategories
  • Add 2 missed sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

homeassistant/components/plugwise/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Show resolved Hide resolved
homeassistant/components/plugwise/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/switch.py Outdated Show resolved Hide resolved
tests/components/plugwise/test_binary_sensor.py Outdated Show resolved Hide resolved
@frenck frenck changed the title Implement entity_registry_enabled_default, add missing EntityCategories Plugwise: Implement entity_registry_enabled_default, add missing EntityCategories Oct 19, 2022
@MartinHjelmare MartinHjelmare changed the title Plugwise: Implement entity_registry_enabled_default, add missing EntityCategories Add entity_registry_enabled_default and missing EntityCategories in Plugwise Oct 19, 2022
@bouwew bouwew force-pushed the pw_default_enable branch from b106e69 to a3700f9 Compare October 21, 2022 05:52
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bouwew 👍

@frenck frenck merged commit 9cd2b83 into home-assistant:dev Oct 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2022
@bouwew bouwew deleted the pw_default_enable branch October 22, 2022 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants