-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new media player enums in forked_daapd #78100
Conversation
Hey there @uvjustin, mind taking a look at this pull request as it has been labeled with an integration ( |
I have #77744 open. Let's work on merging that one first. |
I'vea marked is as ready again. It is the last one blocking #77937 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's just merge this one first then. I'll rebase the other one.
Can you help me have a look at the other one? I have a few more follow on PRs that I would like to get in before the next release else they get stuck in the Hacktoberfest backlog. It's actually quite simple. I'll mark up the changes.
Thanks @uvjustin 👍 |
Proposed change
Use new media player enums in forked_daapd
Currently blocking #78014 and #77937
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: