Force root import of const from other components #78014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
small-pr
epenet
commented
Sep 8, 2022
Comment on lines
+311
to
+342
| if module.startswith("homeassistant.components.") and module.endswith( | ||
| "const" | ||
| ): | ||
| self.add_message("hass-component-root-import", node=node) |
There was a problem hiding this comment.
This one is rare, I have only found it on alexa #78013
pylint/plugins/hass_imports.py
Outdated
Comment on lines
348
to
392
| if node.modname.startswith("homeassistant.components.") and ( | ||
| node.modname.endswith(".const") or "const" in node.names | ||
| ): | ||
| self.add_message("hass-component-root-import", node=node) | ||
| return |
There was a problem hiding this comment.
This one is very common
This was referenced Sep 8, 2022
epenet
force-pushed
the
hass-imports
branch
from
e32a9af to
5707bd6
Compare
This was referenced Sep 11, 2022
This was referenced Sep 12, 2022
This was referenced Sep 13, 2022
epenet
added
the
smash
cdce8p
requested changes
Sep 13, 2022
This was referenced Sep 13, 2022
epenet
force-pushed
the
hass-imports
branch
from
6336bb2 to
c32eff0
Compare
epenet
force-pushed
the
hass-imports
branch
from
c32eff0 to
040b859
Compare
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Based on #77946 (review)
As draft until components are adjustedType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: