-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.10 to CI #59729
Add Python 3.10 to CI #59729
Conversation
f4ca817
to
a462998
Compare
97db253
to
9c26e95
Compare
41cf767
to
33dcb95
Compare
748c2eb
to
0845bab
Compare
I've spend some time today looking into it. Some things I noticed which could be helpful in getting this PR done.
If you're only interested in the
Hope these help 🤞🏻 |
The pandas constrain was here because of Alpine 3.13, which we no longer have. The constrain has been lifted in this PR.
Currently in progress. As a matter of fact, we have released a new wheels builder today that should deal with the last bits of issues we had. We are currently at our third attempt to update to 1.43.0 (thanks to @allenporter for that effort). Ref: #63911
The integration will be removed. This has been discussed already.
Not an issue here.
Not in a hurry. This will not be merged this release anyways, so we have over 1,5 months left ish to make it in time for 2022.3 (that is not a hard deadline though). |
PS: I've "resolved" that one locally (Well threw out anything that would cause an issue, just to get somewhere workable), however, it takes |
😮 Ok, yeah 12h is indeed too long. Maybe a naive idea, what about this? (Assuming we start from a no-conflicts state.) Let's next say we want to update a "normal" dependency. Pip should be able to check fairly quickly if there are any conflicts with the given constraints. If there are, the next step would be to loosen only the conflicting dependency in the requirements file and try again to see if pip can find a solution now. Afterwards update the constraints. At first this is a much more manual process, but maybe steps could be automated as part of the CI pipeline. |
Something like |
The fact we even need to consider those tools is just too stupid to put into words. |
3ba2ae9
to
2d22104
Compare
2b79019
to
480d283
Compare
For Regarding the |
The integration is pending deletion and has 0 active users according to statistics. I think we can safely remove it 😉
We can't, as we need <6.0. Additionally, 5.2.0 imports it conditionally, works :) |
👍🏻
Got confused with the line number there. The invalid use was in L14, same as the conditional import. |
6a652e0
to
442bbef
Compare
Breaking change
The following integrations have been disabled because they have incompatible Python dependencies for Home Assistant.
apcupd
apns
xbee
Proposed change
Adds Python 3.10 to the CI
Notes:
zwave
has now commented dependencies, and tests are disabled. This allows us to ship it with Python 3.9, but not block Python 3.10icloud
tests have been disabled, as those are currently not yet 3.10 compatible. Can be enabled again once we bump pyicloud.Problematic packages:
pyhton-nest
->nest
integration.Update for python3.10 moving Callable usage to collections.abc jkoelker/python-nest#174
velbusaio
->velbus
integration.Python 3.10 incompatible cereal2nd/velbus-aio#29
keyring
used bypyicloud
->icloud
integration.Python 3.10 incompatible picklepete/pyicloud#368
samsungtv
integration. ==> Remove passing loop into sleep in SamsungTV #66030azure
->azure_event_hub
integration ==> Azure Event Hub incompatible with Python 3.10 #66032Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: