Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 incompatible #368

Closed
frenck opened this issue Feb 8, 2022 · 2 comments
Closed

Python 3.10 incompatible #368

frenck opened this issue Feb 8, 2022 · 2 comments

Comments

@frenck
Copy link

frenck commented Feb 8, 2022

The problem

Hi! 👋

I've been working on upgrading Home Assistant to Python 3.10, and noticed this package isn't compatible with Python 3.10.

Python upgrade PR: home-assistant/core#59729

Error from tests:

venv/lib/python3.10/site-packages/keyring/util/properties.py:1: in <module>
    from collections import Callable
E   ImportError: cannot import name 'Callable' from 'collections'

The keyring version used by this project is outdated and need to be bumped:

Currently it is using: keyring>=8.0,<=9.3.1

Could this be fixed/bump to be Python 3.10 compatible? 🙏 ❤️

Thanks!

../Frenck

Environment

  • pyiCloud release with the issue (pip show pyicloud):
  • Last working pyiCloud release (if known):
  • Service causing this issue:
  • Python version (python -V):
  • Operating environment (project deps/Docker/Windows/etc.):

Traceback/Error logs

Additional information

PS: It would also be nice to look at: #289
as this causes a dependency conflict @ Home Assistant.

PS2: Maybe bump & loosen the pinning of tzlocal dependency as well, as it also conflicts.

pyicloud 0.10.2 has requirement click<=7.1.1,>=6.0, but you have click 8.0.3.
pyicloud 0.10.2 has requirement tzlocal==2.0.0, but you have tzlocal 4.1.
@cdce8p
Copy link

cdce8p commented Feb 8, 2022

Some additional information:

@MartinHjelmare
Copy link
Contributor

MartinHjelmare commented Feb 17, 2022

I think we can close here now. 1.0.0 supports Python 3.7 - Python 3.10.

https://github.com/picklepete/pyicloud/releases/tag/1.0.0

@balloob balloob closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants