Skip to content

Conversation

@Noltari
Copy link
Contributor

@Noltari Noltari commented Feb 8, 2021

Power and Link aren't converted from strings to booleans by python-tado, so we need to properly parse before assigning the string value to binary sensors.

Proposed change

Properly parse Tado Zone Power and Link binary sensors.
Fixes #46205.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Power and Link aren't converted from strings to booleans by python-tado, so we
need to properly parse before assigning the string value to binary sensors.

Fixes: 067f2d0 ("Add tado zone binary sensors (home-assistant#44576)")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@probot-home-assistant
Copy link

Hey there @michaelarnauts, @bdraco, mind taking a look at this pull request as its been labeled with an integration (tado) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Noltari Noltari changed the title tado: fix Power and Link binary sensors Fix Tado Power and Link binary sensors Feb 8, 2021
@MartinHjelmare
Copy link
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit fcae840 into home-assistant:dev Feb 8, 2021
@MartinHjelmare MartinHjelmare added this to the 2021.2.2 milestone Feb 8, 2021
balloob pushed a commit that referenced this pull request Feb 8, 2021
Power and Link aren't converted from strings to booleans by python-tado, so we
need to properly parse before assigning the string value to binary sensors.

Fixes: 067f2d0 ("Add tado zone binary sensors (#44576)")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@balloob balloob mentioned this pull request Feb 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
@Noltari Noltari deleted the tado-binary-sensor-power-link branch March 4, 2021 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TADO - sensor.hotwater_power now does the opposite since 2021.2 and moved to binary sensor

6 participants