-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Add tado zone binary sensors #44576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tado zone binary sensors #44576
Conversation
ee915a2 to
4223deb
Compare
|
You'll need to rebase since the changes from #44571 are also in this PR. |
4223deb to
e1b7cd1
Compare
@michaelarnauts done :) |
michaelarnauts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but I'm not really sure what the policy is regarding the description of the breaking change.
|
Please be explicit when naming the entity types that are breaking in the breaking change paragraph. Also briefly explain what users need to do to cope with the breaking change. |
Done:
|
|
Please also mention what users should do to cope with this change. Eg update these entity ids in automations and scripts that depend on the ids. |
Done:
|
These should be binary sensors. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
e1b7cd1 to
c7e8ddb
Compare
|
Please try to avoid squashing commits after review has started, to make it easier for readers to track changes. |
Ok, I will avoid it in the future. |
|
Not in this project. We squash on merge, making the PR clean in the end. Individual commits are trackable/more visible to see what has been changed over time in the PR during a review. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Please add the Binary Sensor |
|
|
Thanks! |
Breaking change
Tado zone sensors will be replaced by their corresponding binary_sensors. Therefore, users will have to update lovelace panels, scripts and automations referring to the following sensors by their corresponding binary sensor (replace sensor with binary_sensor)
The following state attributes have been removed:
Proposed change
Use binary sensors where appropriate (for Tado Zones) instead of normal sensors.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: