Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intesishome passing coroutine to HassJob #43837

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

tehbrd
Copy link
Contributor

@tehbrd tehbrd commented Dec 1, 2020

Not allowed to pass coroutines to hassjob.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Not allowed to pass coroutines to hassjob.
@homeassistant
Copy link
Contributor

Hi @tehbrd,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @jnimmo, mind taking a look at this pull request as its been labeled with an integration (intesishome) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work, the connect method does not support arguments.

@ludeeus ludeeus changed the title Update climate.py Fix issue with passing coroutine to HassJob Dec 2, 2020
@ludeeus ludeeus marked this pull request as draft December 2, 2020 14:00
@MartinHjelmare MartinHjelmare changed the title Fix issue with passing coroutine to HassJob Fix intesishome passing coroutine to HassJob Dec 3, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Mark the PR ready for review and we can merge.

@MartinHjelmare
Copy link
Member

Oh, we marked it draft. I'll just mark it ready and merge then. 👍

@MartinHjelmare MartinHjelmare marked this pull request as ready for review December 3, 2020 00:57
@MartinHjelmare MartinHjelmare merged commit 4c7e17c into home-assistant:dev Dec 3, 2020
@balloob balloob added this to the 1.0.0 milestone Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intesishome sync error
6 participants