Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlarmDecoder config flow fixes #40037

Merged
merged 12 commits into from
Sep 15, 2020
Merged

AlarmDecoder config flow fixes #40037

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4ebc438
refactor baud parameter
ajschmidt8 Sep 13, 2020
ff10c50
use async_add_executor_job for close()
ajschmidt8 Sep 13, 2020
14b9443
refactor service registration
ajschmidt8 Sep 13, 2020
70f68d9
rename devices -> entities
ajschmidt8 Sep 13, 2020
fb1d288
use common key for strings.json
ajschmidt8 Sep 13, 2020
b150394
setup config entry before options flow
ajschmidt8 Sep 13, 2020
01456fa
Merge remote-tracking branch 'upstream/dev' into ad-config-flow-fixes
ajschmidt8 Sep 14, 2020
fe09295
rm extraneous controller var
ajschmidt8 Sep 14, 2020
e4e79b4
rename var: device -> entity
ajschmidt8 Sep 14, 2020
d02254f
use async_add_executor_job for controller open/close in config_flow
ajschmidt8 Sep 14, 2020
d0adca7
use async_add_executor_job for controller.open in async_setup_entry
ajschmidt8 Sep 14, 2020
5d9484f
consolidate executor fns
ajschmidt8 Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
consolidate executor fns
  • Loading branch information
@ajschmidt8
ajschmidt8 committed Sep 15, 2020
commit 5d9484f90335241d50f22a5a380dccf7e68a4cb5
8 changes: 6 additions & 2 deletions homeassistant/components/alarmdecoder/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,13 @@ async def async_step_protocol(self, user_input=None):
device = SerialDevice(interface=path)

controller = AdExt(device)

def test_connection():
controller.open(baud)
controller.close()

try:
await self.hass.async_add_executor_job(controller.open, baud)
await self.hass.async_add_executor_job(controller.close)
await self.hass.async_add_executor_job(test_connection)
return self.async_create_entry(
title=title, data={CONF_PROTOCOL: self.protocol, **connection}
)
Expand Down