-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlarmDecoder config flow fixes #40037
AlarmDecoder config flow fixes #40037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the config flow to use the executor when opening the controller connection.
@MartinHjelmare done in d02254f & d0adca7. I tested these locally and they worked, but please review the second commit in particular to make sure it looks okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Proposed change
This PR addresses some comments from @MartinHjelmare in #37998 after it was merged.
Specifically, the changes include:
async_add_executor_job
forcontroller.close()
devices
toentities
return True
statementscommon
values instrings.json
baud
variable usage to remove some code duplication from testsType of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: