Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlarmDecoder config flow fixes #40037

Merged
merged 12 commits into from
Sep 15, 2020

Conversation

ajschmidt8
Copy link
Contributor

Proposed change

This PR addresses some comments from @MartinHjelmare in #37998 after it was merged.

Specifically, the changes include:

  • Using async_add_executor_job for controller.close()
  • Refactoring service registrations
  • Renaming devices to entities
  • Removing some extraneous return True statements
  • Using some common values in strings.json
  • Adding config entries before options flow in unit tests
  • Refactoring the baud variable usage to remove some code duplication from tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the config flow to use the executor when opening the controller connection.

homeassistant/components/alarmdecoder/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/alarmdecoder/__init__.py Outdated Show resolved Hide resolved
@ajschmidt8
Copy link
Contributor Author

Please also update the config flow to use the executor when opening the controller connection.

@MartinHjelmare done in d02254f & d0adca7.

I tested these locally and they worked, but please review the second commit in particular to make sure it looks okay

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 66bb6a6 into home-assistant:dev Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants