Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bond cover assumed state and local polling #37666

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Add bond cover assumed state and local polling #37666

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
629b4bd
Declare Bond covers as having assumed state, setup local polling for …
prystupa Jul 8, 2020
56b571d
Declare Bond covers as having assumed state, setup local polling for …
prystupa Jul 9, 2020
0b78911
Declare Bond covers as having assumed state, setup local polling for …
prystupa Jul 9, 2020
ee25507
Declare Bond covers as having assumed state, setup local polling for …
prystupa Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Declare Bond covers as having assumed state, setup local polling for … 
…state updates (apply feedback from PR review)
  • Loading branch information
@prystupa
prystupa committed Jul 9, 2020
commit 0b78911708c9c0bdb4be39529fd4ef12f4e0fe54
24 changes: 5 additions & 19 deletions tests/components/bond/test_cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
"""Tests for the Bond cover device."""
from datetime import timedelta
import logging

from bond import BOND_DEVICE_TYPE_MOTORIZED_SHADES

from homeassistant import core
from homeassistant.components.cover import DOMAIN as COVER_DOMAIN
from homeassistant.components.homeassistant import (
DOMAIN as HA_DOMAIN,
SERVICE_UPDATE_ENTITY,
)
from homeassistant.const import (
ATTR_ENTITY_ID,
SERVICE_CLOSE_COVER,
SERVICE_OPEN_COVER,
SERVICE_STOP_COVER,
)
from homeassistant.helpers.entity_registry import EntityRegistry
from homeassistant.setup import async_setup_component
from homeassistant.util import utcnow

from ...common import async_fire_time_changed
prystupa marked this conversation as resolved.
Show resolved Hide resolved
from .common import setup_platform

from tests.async_mock import patch
Expand Down Expand Up @@ -116,7 +114,6 @@ async def test_stop_cover(hass: core.HomeAssistant):
async def test_update_reports_open_cover(hass: core.HomeAssistant):
"""Tests that update command sets correct state when Bond API reports cover is open."""

await async_setup_component(hass, HA_DOMAIN, {})
with patch(
"homeassistant.components.bond.Bond.getDeviceIds", return_value=TEST_DEVICE_IDS
), patch(
Expand All @@ -129,12 +126,7 @@ async def test_update_reports_open_cover(hass: core.HomeAssistant):
with patch(
"homeassistant.components.bond.Bond.getDeviceState", return_value={"open": 1}
):
await hass.services.async_call(
HA_DOMAIN,
SERVICE_UPDATE_ENTITY,
{ATTR_ENTITY_ID: "cover.name_1"},
blocking=True,
)
async_fire_time_changed(hass, utcnow() + timedelta(seconds=30))
await hass.async_block_till_done()

assert hass.states.get("cover.name_1").state == "open"
Expand All @@ -143,7 +135,6 @@ async def test_update_reports_open_cover(hass: core.HomeAssistant):
async def test_update_reports_closed_cover(hass: core.HomeAssistant):
"""Tests that update command sets correct state when Bond API reports cover is closed."""

await async_setup_component(hass, HA_DOMAIN, {})
with patch(
"homeassistant.components.bond.Bond.getDeviceIds", return_value=TEST_DEVICE_IDS
), patch(
Expand All @@ -156,12 +147,7 @@ async def test_update_reports_closed_cover(hass: core.HomeAssistant):
with patch(
"homeassistant.components.bond.Bond.getDeviceState", return_value={"open": 0}
):
await hass.services.async_call(
HA_DOMAIN,
SERVICE_UPDATE_ENTITY,
{ATTR_ENTITY_ID: "cover.name_1"},
blocking=True,
)
async_fire_time_changed(hass, utcnow() + timedelta(seconds=30))
await hass.async_block_till_done()

assert hass.states.get("cover.name_1").state == "closed"