Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bond cover assumed state and local polling #37666

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

prystupa
Copy link
Contributor

@prystupa prystupa commented Jul 8, 2020

Proposed change

Informing HA that Bond integration covers have assumed state tracked by Bond hub, implement polling for state

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title Declare Bond covers as having assumed state, setup local polling for … Add bond cover assumed state and local polling Jul 9, 2020
homeassistant/components/bond/cover.py Outdated Show resolved Hide resolved
homeassistant/components/bond/cover.py Outdated Show resolved Hide resolved
tests/components/bond/test_cover.py Outdated Show resolved Hide resolved
…state updates (apply feedback from PR review)
@prystupa prystupa requested a review from MartinHjelmare July 9, 2020 12:48
…state updates (apply feedback from PR review)
…state updates (apply feedback from PR review)
@prystupa prystupa requested a review from MartinHjelmare July 9, 2020 13:19
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elupus
Copy link
Contributor

elupus commented Jul 9, 2020

Wait.. If you can fetch state from hub, and that is a valid state. Assumed state should not be set to true.

@prystupa
Copy link
Contributor Author

prystupa commented Jul 9, 2020

Wait.. If you can fetch state from hub, and that is a valid state. Assumed state should not be set to true.

State inside the Hub is assumed. Bond does not know if you use your remote directly. So if we don't declare assumed, then user can get in trouble, when state would not match, but you disables choices

@ctalkington ctalkington merged commit 69a8ba2 into home-assistant:dev Jul 9, 2020
@prystupa prystupa deleted the bond-assumed-state branch July 9, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants