Correct socket use in cert_expiry platform #25011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make sure we use same family for ssl socket and connection
getaddrinfo result could be different from what connection
was made with. It also blocks potential use of
happy eye balls algorithm
This also fixes lingering sockets until python garbage
collection as well as add support to display availability of sensor.
This may fix related issues, but i've not really reproduced them.
Related issue (if applicable): #10550 #12607
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
[ ] Documentation added/updated in home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
[ ] The manifest file has all fields filled out correctly. Update and include derived files by runningpython3 -m script.hassfest
.[ ] New or updated dependencies have been added torequirements_all.txt
by runningpython3 -m script.gen_requirements_all
.[ ] Untested files have been added to.coveragerc
.If the code does not interact with devices: