-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing yeelight models mapping #24963
Conversation
Hey there @rytilahti, @zewelor, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
lamp1 is whitetemp for sure, not mono ? Its possible to set_mode to nightlight on it ? |
It is not possible to
PS On the other hand |
Sorry does mode moonlight works on it. For effects I've recently whitelisted effets, that are supported on non color light, does they work on this lamp ? |
For me it looks good. |
can you update the issue number is fixes, as it points to a different one (missing 2 at the end by looks of it) |
By whitelisted effects you mean just "Slow temp"? No, it does nothing or I noticed nothing. @aidbish thanks for spotting, somehow |
Its not updated because it reads model specs from https://gitlab.com/stavros/python-yeelight/blob/master/yeelight/main.py#L37 . It would require to add model also there and update python-yeelight. |
So I'm leaving this to you. I'm bringing |
So, if I'm reading it correctly, this fixes a known issue without breaking anything, so I think this should get merged. Not updating the nightlight state is another issue, which can be solved in a separate PR. Thanks for the PR @cadavre and thanks @zewelor for your insight on how to fix that another issue! |
… into hive_water_heater * 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits) Sensibo, add HVAC_MODE_OFF (home-assistant#25016) Add support for arcam fmj receivers (home-assistant#24621) Enphase envoy individual inverter production (home-assistant#24445) Implement Twilio SMS notify MediaUrl support (home-assistant#24971) Climate 1.0 (home-assistant#23899) Correct socket use in cert_expiry platform (home-assistant#25011) Added missing yeelight models mapping (home-assistant#24963) Install requirements for integrations in packages before importing them. (home-assistant#25005) Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765) Upgrade hdate==0.8.8 (home-assistant#25008) upgrade switchmate to latest lib (home-assistant#25006) Test dependency updates (home-assistant#25004) Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809) Sleepiq single sleeper crash (home-assistant#24941) Changes as per code review of home-assistant#24646 (home-assistant#24917) Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998) Adds Stale Probot for issues (home-assistant#24985) Adds Lock Threads Probot (home-assistant#24984) Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821) Fix errors if rest source becomes unavailable (home-assistant#24986) ... # Conflicts: # homeassistant/components/hive/__init__.py # homeassistant/components/hive/climate.py
Breaking Change:
No breaking changes.
Description:
Adds support for missing
yeelight
models.Related issue (if applicable):
Fixes #24962
Checklist:
tox
.