Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookidoo exotic domains #134676

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Jan 4, 2025

Proposed change

Fix the api endpoint for exotic countries, which do not have their own domain.

https://github.com/miaucl/cookidoo-api/releases/tag/0.11.2
https://github.com/miaucl/cookidoo-api/blob/master/CHANGELOG.md

The localization options contain the info, whether it is a shared or its own domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.1.1 milestone Jan 4, 2025
@frenck frenck merged commit 8a880d6 into home-assistant:dev Jan 4, 2025
61 checks passed
@miaucl miaucl deleted the cookidoo_exotic_domains branch January 4, 2025 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookidoo integration unable to connect and retrieve data from cookidoo
3 participants