Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused aiohttp ENABLE_CLEANUP_CLOSED code path #129629

Closed

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 1, 2024

Proposed change

We only support Python 3.12+. ENABLE_CLEANUP_CLOSED is always evaluated to True.
Added originally with

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner November 1, 2024 11:59
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Nov 1, 2024
@cdce8p cdce8p requested a review from bdraco November 1, 2024 11:59
@bdraco
Copy link
Member

bdraco commented Nov 1, 2024

We are likely about to make cleanup_closed a NOOP

aio-libs/aiohttp#9590

@cdce8p
Copy link
Member Author

cdce8p commented Nov 1, 2024

We are likely about to make cleanup_closed a NOOP

aio-libs/aiohttp#9590

👍🏻 Technically we still support 3.12.0 as well though. We can remove it completely once we drop 3.12 next year.

@bdraco
Copy link
Member

bdraco commented Nov 1, 2024

I was thinking we could change the constant here to return False for 3.12.7+ and 3.13.1+ so we can get ahead of aio-libs/aiohttp#9590

@cdce8p
Copy link
Member Author

cdce8p commented Nov 1, 2024

You're the performance expert, but if it should be a noop in the future, would it even make a difference to set it to false explicitly? I'd expect the noop to not care if it's True or False.

@bdraco
Copy link
Member

bdraco commented Nov 1, 2024

It won't make any difference once aiohttp makes the change but I'm not sure when we are going to do that in aiohttp so it would be nicer to do it here ahead of time.

@cdce8p
Copy link
Member Author

cdce8p commented Nov 1, 2024

Fine by me. Closing this one then.

@cdce8p cdce8p closed this Nov 1, 2024
@cdce8p cdce8p deleted the remove-aiohttp-cleanup-closed branch November 1, 2024 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants