Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makecleanup_closed a noop with python 3.12.7+ and 3.13.1+ #9590

Closed
bdraco opened this issue Oct 29, 2024 · 0 comments · Fixed by #9726
Closed

Makecleanup_closed a noop with python 3.12.7+ and 3.13.1+ #9590

bdraco opened this issue Oct 29, 2024 · 0 comments · Fixed by #9726
Assignees
@bdraco

Comments

@bdraco
Copy link
Member

bdraco commented Oct 29, 2024

We can probably make cleanup closed a no op on new enough python versions

          > We might be able to get rid of `cleanup_closed` as well

@bdraco Do you want to take a look at that?

Originally posted by @Dreamsorcerer in #3122 (comment)
@bdraco bdraco self-assigned this Oct 29, 2024
This was referenced Oct 29, 2024
Closed
Closed
@bdraco bdraco changed the title > We might be able to get rid of cleanup_closed as well Makecleanup_closed a noop with python 3.12.7+ and 3.13.1+ Oct 29, 2024
@bdraco bdraco mentioned this issue Nov 1, 2024
Closed
19 tasks
@bdraco bdraco mentioned this issue Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdraco bdraco

Labels
None yet
Projects
Sprint @ Man Group London Hackathon 2024, Nov 9
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make enable_cleanup_closed a NOOP for Python 3.12.7+ and 3.13.1+ aio-libs/aiohttp
1 participant
@bdraco