Convert Bang & Olufsen testing logging patches to caplog #124366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: bang_olufsen
small-pr
joostlek
requested changes
Aug 21, 2024
Comment on lines
+750
to
+751
| "media_player", | ||
| "play_media", |
There was a problem hiding this comment.
While we're at it, can we add constatns for this?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Aug 21, 2024
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Aug 22, 2024
* dev: (642 commits) Improve config flow type hints (part 4) (home-assistant#124348) Improve config flow type hints (part 1) (home-assistant#124343) Add tests for Bring integration (home-assistant#123087) Add DROP Alert product support (home-assistant#117867) update ttn_client - fix crash with SenseCAP devices (home-assistant#124370) Add Aranet Radon Plus support (home-assistant#124197) Fix Spotify Media Browsing fails for new config entries (home-assistant#124368) Convert Bang & Olufsen testing logging patches to caplog (home-assistant#124366) Remove unneeded check for Bang & Olufsen events and device update (home-assistant#124363) Bump async-interrupt to 1.2.0 (home-assistant#124360) Rename OpenThermGatewayDevice to OpenThermGatewayHub (home-assistant#124361) Fix Weatherflow Cloud lightning (home-assistant#124082) Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower (home-assistant#117153) Disable Habitica deprecated entities by default (home-assistant#123522) Add test cases for ViCare entities (home-assistant#122983) Add tests for IronOS integration (home-assistant#123078) Fix state name for binary_sensor Power from clear/detected to on/off (home-assistant#116994) Extend blebox shutterbox tilt support (home-assistant#110547) blebox: use blebox_uniapi.cover.BleboxCoverState enum members instead of plain integers (home-assistant#124302) Add custom panel for LCN configuration (home-assistant#108664) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use Pytest's caplog for checking logs instead of patching specific loggers
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: