Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Weatherflow Cloud lightning #124082

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Fix Weatherflow Cloud lightning #124082

merged 6 commits into from
Aug 21, 2024

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Aug 16, 2024 •
edited
Loading

Proposed change

Fix for lightning cases that was crashing: #124071

the epoch could be NULL
image

And this code block couldn't handle it
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jeeftor jeeftor marked this pull request as ready for review August 16, 2024 21:32
@jeeftor jeeftor force-pushed the weatherflow_lightning_none branch from 6d21831 to 2abc5b9 Compare August 17, 2024 12:40
joostlek
joostlek requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the testing. I do like that we add a new fixture, but we can just overwrite the current mock in the test with the failure (so we don't need a separate mock fixture) and we don't have to create a whole snapshot for this. It currently hides what we are testing. The test is named test_all_entities_with_lightning_error, but when I am reading the test I can't find out what that actually tests. So rather just replace it with a hass.states.get().state == STATE_UNKNOWN, which also covers the thing we want to test, and makes the test clearer

homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 17, 2024 14:28
@MartinHjelmare MartinHjelmare changed the title Bug Fix - Weatherflow Cloud Fix Weatherflow Cloud lightning Aug 17, 2024
@jeeftor jeeftor requested a review from joostlek August 19, 2024 14:44
@jeeftor
Copy link
Contributor Author

jeeftor commented Aug 19, 2024

@joostlek - did I update the test correctly by adding an assert? Or did you want me to fold the changed value into the 1st test?

@joostlek
Copy link
Member

My point being, you don't need a whole snapshot of all the entities and state just to check if one sensor renders as unknown

@jeeftor
Copy link
Contributor Author

jeeftor commented Aug 20, 2024

removed.

@jeeftor jeeftor marked this pull request as ready for review August 20, 2024 16:17
@joostlek joostlek merged commit 9de90ca into home-assistant:dev Aug 21, 2024
26 checks passed
@jeeftor jeeftor deleted the weatherflow_lightning_none branch August 21, 2024 16:25
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 22, 2024
@raman325
Merge branch 'dev' into label
5797c23 
* dev: (642 commits)
  Improve config flow type hints (part 4) (home-assistant#124348)
  Improve config flow type hints (part 1) (home-assistant#124343)
  Add tests for Bring integration (home-assistant#123087)
  Add DROP Alert product support (home-assistant#117867)
  update ttn_client - fix crash with SenseCAP devices (home-assistant#124370)
  Add Aranet Radon Plus support (home-assistant#124197)
  Fix Spotify Media Browsing fails for new config entries (home-assistant#124368)
  Convert Bang & Olufsen testing logging patches to caplog (home-assistant#124366)
  Remove unneeded check for Bang & Olufsen events and device update (home-assistant#124363)
  Bump async-interrupt to 1.2.0 (home-assistant#124360)
  Rename OpenThermGatewayDevice to OpenThermGatewayHub (home-assistant#124361)
  Fix Weatherflow Cloud lightning (home-assistant#124082)
  Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower (home-assistant#117153)
  Disable Habitica deprecated entities by default (home-assistant#123522)
  Add test cases for ViCare entities (home-assistant#122983)
  Add tests for IronOS integration (home-assistant#123078)
  Fix state name for binary_sensor Power from clear/detected to on/off (home-assistant#116994)
  Extend blebox shutterbox tilt support (home-assistant#110547)
  blebox: use blebox_uniapi.cover.BleboxCoverState enum members instead of plain integers (home-assistant#124302)
  Add custom panel for LCN configuration (home-assistant#108664)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
MartinHjelmare
MartinHjelmare reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in a new PR. Thanks!

tests/components/weatherflow_cloud/conftest.py


#
# @pytest.fixture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code. Please remove it.

@home-assistant home-assistant unlocked this conversation Aug 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed has-tests integration: weatherflow_cloud Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeeftor @joostlek @MartinHjelmare