-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set zwave_js voltage sensor suggested precision #107116
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we going with 0? Are we looking for the least common denominator so that they all match? I would expect that by default users would want more precision than that, but maybe that is just me
I was only considering AC voltage where my assumption was that you don't care if the voltage is fluctuating less then a Volt in household applications. The voltage for my Aeotec smartplug connected to a wall socket fluctuates between 215 and 228 V, normally. For DC voltage you probably want 2 decimals, but I don't have a single Z-Wave sensor that measures that so I assumed it isn't very common. Battery level sensors are common but they all measure percent. |
makes sense and I don't think there is a structured way to know if a multilevel sensor is AC or DC so I guess this default makes sense |
* upstream/dev: (2071 commits) Set zwave_js voltage sensor suggested precision (home-assistant#107116) Bump bluetooth-adapters to 0.17.0 (home-assistant#107195) Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203) Fix conversation snapshots (home-assistant#107196) Report missing entities/areas instead of failing to match in Assist (home-assistant#107151) Bump to PyTado 0.17.3 (home-assistant#107181) Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183) Fix tplink overloading power strips (home-assistant#104208) Update sensorpush-ble library to 1.6.1 (home-assistant#107168) Bump aiohomekit to 3.1.2 (home-assistant#107177) Introduce base entity in streamlabs water (home-assistant#107095) Clean up outdated entity replacement logic in Guardian (home-assistant#107160) Add conversation_id parameter to conversation.process service (home-assistant#106078) Pass aiohttp clientsession to tedee integration (home-assistant#107089) Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175) Remove precision in streamlabs water (home-assistant#107096) Pass down language to hassil (home-assistant#106490) Use snapshots in Glances sensor tests (home-assistant#107159) Cache homekit_controller supported features (home-assistant#106702) Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752) ...
Breaking change
Set suggested precision to 0 decimals for voltage sensors with native unit in V. This will uniform the display precision of voltage sensors where there otherwise seems to be a variety of precision reported from different devices.
If you want to change the precision you can do that in the sensor options in the GUI or with a template sensor.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: