Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set zwave_js voltage sensor suggested precision #107116

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Jan 4, 2024

Breaking change

Set suggested precision to 0 decimals for voltage sensors with native unit in V. This will uniform the display precision of voltage sensors where there otherwise seems to be a variety of precision reported from different devices.

If you want to change the precision you can do that in the sensor options in the GUI or with a template sensor.

Proposed change

  • Set suggested precision to 0 decimals for voltage sensors with native unit in V. I don't own any sensors that report in mV so I haven't changed that sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2024

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Test voltage sensor suggested precision Set voltage sensor suggested precision Jan 4, 2024
@MartinHjelmare MartinHjelmare changed the title Set voltage sensor suggested precision Set zwave_js voltage sensor suggested precision Jan 4, 2024
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we going with 0? Are we looking for the least common denominator so that they all match? I would expect that by default users would want more precision than that, but maybe that is just me

@MartinHjelmare
Copy link
Member Author

MartinHjelmare commented Jan 4, 2024

I was only considering AC voltage where my assumption was that you don't care if the voltage is fluctuating less then a Volt in household applications. The voltage for my Aeotec smartplug connected to a wall socket fluctuates between 215 and 228 V, normally.

For DC voltage you probably want 2 decimals, but I don't have a single Z-Wave sensor that measures that so I assumed it isn't very common. Battery level sensors are common but they all measure percent.

@raman325
Copy link
Contributor

raman325 commented Jan 5, 2024

I was only considering AC voltage where my assumption was that you don't care if the voltage is fluctuating less then a Volt in household applications. The voltage for my Aeotec smartplug connected to a wall socket fluctuates between 215 and 228 V, normally.

For DC voltage you probably want 2 decimals, but I don't have a single Z-Wave sensor that measures that so I assumed it isn't very common. Battery level sensors are common but they all measure percent.

makes sense and I don't think there is a structured way to know if a multilevel sensor is AC or DC so I guess this default makes sense

@raman325 raman325 merged commit 00ff93a into dev Jan 5, 2024
23 checks passed
@raman325 raman325 deleted the add-zwave_js-voltage-suggested-precision branch January 5, 2024 06:03
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 5, 2024
* upstream/dev: (2071 commits)
  Set zwave_js voltage sensor suggested precision (home-assistant#107116)
  Bump bluetooth-adapters to 0.17.0 (home-assistant#107195)
  Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203)
  Fix conversation snapshots (home-assistant#107196)
  Report missing entities/areas instead of failing to match in Assist (home-assistant#107151)
  Bump to PyTado 0.17.3 (home-assistant#107181)
  Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183)
  Fix tplink overloading power strips (home-assistant#104208)
  Update sensorpush-ble library to 1.6.1 (home-assistant#107168)
  Bump aiohomekit to 3.1.2 (home-assistant#107177)
  Introduce base entity in streamlabs water (home-assistant#107095)
  Clean up outdated entity replacement logic in Guardian (home-assistant#107160)
  Add conversation_id parameter to conversation.process service (home-assistant#106078)
  Pass aiohttp clientsession to tedee integration (home-assistant#107089)
  Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175)
  Remove precision in streamlabs water (home-assistant#107096)
  Pass down language to hassil (home-assistant#106490)
  Use snapshots in Glances sensor tests (home-assistant#107159)
  Cache homekit_controller supported features (home-assistant#106702)
  Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants