Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass aiohttp clientsession to tedee integration #107089

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Pass aiohttp clientsession to tedee integration #107089

merged 4 commits into from
Jan 4, 2024

Conversation

zweckj
Copy link
Contributor

@zweckj zweckj commented Jan 4, 2024 •
edited
Loading

Breaking change

Proposed change

Pass aiohttp clientsession to tedee integration, bump pytedee_async to a version that supports this (https://github.com/zweckj/pytedee_async/releases/tag/v0.2.6)

Diff (0.2.1 -> 0.2.6)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2024

Hey there @patrickhilker, mind taking a look at this pull request as it has been labeled with an integration (tedee) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tedee can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tedee Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@zweckj zweckj mentioned this pull request Jan 4, 2024
Merged
20 tasks
zweckj and others added 3 commits January 4, 2024 11:50
@zweckj @autinerd
Update homeassistant/components/tedee/config_flow.py
563c748 
Co-authored-by: Sid <27780930+autinerd@users.noreply.github.com>
@zweckj @autinerd
Update homeassistant/components/tedee/__init__.py
bb27251 
Co-authored-by: Sid <27780930+autinerd@users.noreply.github.com>
@zweckj
move to coordinator
26bbc54
@autinerd
Copy link
Contributor

autinerd commented Jan 4, 2024

Please bump in separate PR or check the "Dependency upgrade" checkbox as well. (In my opinion, it could be okay to do both in this small PR)

@zweckj
Copy link
Contributor Author

zweckj commented Jan 4, 2024

Please bump in separate PR or check the "Dependency upgrade" checkbox as well. (In my opinion, it could be okay to do both in this small PR)

added to description

@jpbede jpbede merged commit 34e6fa3 into home-assistant:dev Jan 4, 2024
53 checks passed
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 5, 2024
@raman325
Merge remote-tracking branch 'upstream/dev' into device
8eea524 
* upstream/dev: (2071 commits)
  Set zwave_js voltage sensor suggested precision (home-assistant#107116)
  Bump bluetooth-adapters to 0.17.0 (home-assistant#107195)
  Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203)
  Fix conversation snapshots (home-assistant#107196)
  Report missing entities/areas instead of failing to match in Assist (home-assistant#107151)
  Bump to PyTado 0.17.3 (home-assistant#107181)
  Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183)
  Fix tplink overloading power strips (home-assistant#104208)
  Update sensorpush-ble library to 1.6.1 (home-assistant#107168)
  Bump aiohomekit to 3.1.2 (home-assistant#107177)
  Introduce base entity in streamlabs water (home-assistant#107095)
  Clean up outdated entity replacement logic in Guardian (home-assistant#107160)
  Add conversation_id parameter to conversation.process service (home-assistant#106078)
  Pass aiohttp clientsession to tedee integration (home-assistant#107089)
  Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175)
  Remove precision in streamlabs water (home-assistant#107096)
  Pass down language to hassil (home-assistant#106490)
  Use snapshots in Glances sensor tests (home-assistant#107159)
  Cache homekit_controller supported features (home-assistant#106702)
  Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@autinerd autinerd autinerd approved these changes

@joostlek joostlek joostlek approved these changes

@jpbede jpbede jpbede approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality integration: tedee Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zweckj @autinerd @jpbede @joostlek