-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webmin integration #106976
Add webmin integration #106976
Conversation
a234e55
to
538282d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thanks for the integration 👍 Here is my first quick review
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep this going :)
One question to the translation strings: Would it be better to first create a PR for the System Monitor integration to switch to strings.json? Then I can reference them here as well, because the sensors will be quite similar. |
Hm that would reduce the duplication of strings yes, but the entity names from System Monitor slightly differ from yours. System Monitor appends something to then name:
|
Talked about that with an other member, integrations should not reference to other strings from other integrations |
I will use placeholders as well when I add the disk and network sensors.
Okay, then I will create the strings for my integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things and then I think we're good to go 👍
But I would like a other member also have a look
One question I have, should I disable all entites per default like |
I guess that would be a good idea as you plan to add more sensors. Depending on the system Webmin is running on, that could be a lot. |
Is done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @autinerd, great job! This looks good to me now 👍
Proposed change
This adds the Webmin integration.
Webmin is a Web UI to manage and administrate servers, mostly in the Linux environment.
The data is polled via a XML-RPC API.
My goal is it to have the sensors as much as possible similar to the System Monitor integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: