Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webmin integration #5052

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add webmin integration #5052

merged 1 commit into from
Feb 26, 2024

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Jan 3, 2024 •
edited
Loading

Proposed change

Adds the logo and icon for Webmin.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@autinerd autinerd mentioned this pull request Jan 3, 2024
Merged
8 tasks
@autinerd autinerd marked this pull request as ready for review January 3, 2024 18:32
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 4, 2024
frenck
frenck approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 4, 2024
@jpbede jpbede added the parent-merged The parent PR has been merged already label Feb 26, 2024
@klaasnicolaas klaasnicolaas merged commit e43fe0f into home-assistant:master Feb 26, 2024
5 checks passed
@autinerd autinerd deleted the webmin-integration branch February 26, 2024 20:11
Athozs pushed a commit to Athozs/brands that referenced this pull request Aug 30, 2024
@autinerd @Athozs
Add webmin integration (home-assistant#5052)
6d4bdd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autinerd @frenck @jpbede @klaasnicolaas