Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of dhcp integration client processing #106137

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 20, 2023

Proposed change

We were using run_callback_threadsafe here which has the overhead of creating a future and waiting for the result when we throw it away. We shouldn't use this helper unless we need to wait for the result. There are other places in the codebase that currently do this that I will audit and adjust in future PRs

Screenshot 2023-12-20 at 12 04 02 PM

Noticed this while working on #105884

async_process_clien

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We were using run_callback_threadsafe here which has the overhead
of creating a future and waiting for the result when we throw
it away.
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch @bdraco 👍

@jpbede jpbede merged commit 235914c into dev Dec 21, 2023
53 checks passed
@jpbede jpbede deleted the dhcp_callback branch December 21, 2023 08:28
@bdraco
Copy link
Member Author

bdraco commented Dec 21, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants