Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prices service calls for easyEnergy #105175

Merged
merged 12 commits into from
Dec 18, 2023

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Dec 6, 2023

Proposed change

Adds service calls with which users could request the hourly price data, a much requested feature, which is still missing from the intergrion to date. This is a modified version of the pull request (#101374) at Energyzero.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@klaasnicolaas klaasnicolaas changed the title Add prices service calls for easyEnergy WIP: Add prices service calls for easyEnergy Dec 6, 2023
homeassistant/components/easyenergy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 7, 2023 10:59
@home-assistant
Copy link

home-assistant bot commented Dec 7, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaasnicolaas klaasnicolaas mentioned this pull request Dec 7, 2023
20 tasks
@klaasnicolaas klaasnicolaas force-pushed the klaas-2023-026 branch 2 times, most recently from 7740a3c to 6b2df3d Compare December 7, 2023 14:06
@klaasnicolaas klaasnicolaas marked this pull request as ready for review December 7, 2023 14:24
@home-assistant home-assistant bot requested a review from edenhaus December 7, 2023 14:24
@klaasnicolaas klaasnicolaas changed the title WIP: Add prices service calls for easyEnergy Add prices service calls for easyEnergy Dec 7, 2023
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 13, 2023 07:58
@klaasnicolaas klaasnicolaas marked this pull request as ready for review December 13, 2023 12:18
@home-assistant home-assistant bot requested a review from edenhaus December 13, 2023 12:18
homeassistant/components/easyenergy/const.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/services.py Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/strings.json Outdated Show resolved Hide resolved
homeassistant/components/easyenergy/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 13, 2023 15:45
@klaasnicolaas klaasnicolaas marked this pull request as ready for review December 13, 2023 16:08
@home-assistant home-assistant bot requested a review from edenhaus December 13, 2023 16:08
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @klaasnicolaas 👍

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests

@home-assistant home-assistant bot marked this pull request as draft December 14, 2023 08:00
@klaasnicolaas klaasnicolaas marked this pull request as ready for review December 14, 2023 10:19
@home-assistant home-assistant bot requested a review from edenhaus December 14, 2023 10:19
@edenhaus edenhaus merged commit e59e1d7 into home-assistant:dev Dec 18, 2023
23 checks passed
@klaasnicolaas klaasnicolaas mentioned this pull request Dec 18, 2023
20 tasks
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants