Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Energyzero get_gas_prices and get_energy_price services #101374

Merged

Conversation

iamrgroot
Copy link
Contributor

@iamrgroot iamrgroot commented Oct 4, 2023

Proposed change

This re-adds the EnergyZero get prices service calls. This time using the EnergyZero client from the existing coordinator. (Re-using the already fetched data is not a solution because of the custom date filters.) See #100370, #100499, #101332 for relevant previous attempts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft December 18, 2023 08:59
@iamrgroot iamrgroot marked this pull request as ready for review December 18, 2023 09:06
@home-assistant home-assistant bot marked this pull request as draft December 18, 2023 09:40
@iamrgroot iamrgroot marked this pull request as ready for review December 18, 2023 10:45
@home-assistant home-assistant bot requested a review from edenhaus December 18, 2023 10:45
@home-assistant home-assistant bot marked this pull request as draft December 18, 2023 12:36
@iamrgroot iamrgroot marked this pull request as ready for review December 19, 2023 07:32
@home-assistant home-assistant bot requested a review from edenhaus December 19, 2023 07:32
tests/components/energyzero/test_services.py Outdated Show resolved Hide resolved
tests/components/energyzero/test_services.py Outdated Show resolved Hide resolved
tests/components/energyzero/test_services.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 19, 2023 15:34
@iamrgroot iamrgroot marked this pull request as ready for review December 19, 2023 21:03
@home-assistant home-assistant bot requested a review from edenhaus December 19, 2023 21:03
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamrgroot 👍

@edenhaus edenhaus merged commit d5c7ae5 into home-assistant:dev Dec 21, 2023
23 checks passed
@iamrgroot iamrgroot deleted the feat/energyzero-service-response branch December 21, 2023 14:49
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants