Add options flow to Roborock #104345
Merged
Add options flow to Roborock #104345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
reviewed
Nov 22, 2023
20 tasks
SLaks
reviewed
Dec 17, 2023
SLaks
approved these changes
Dec 19, 2023
edenhaus
requested changes
Feb 7, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Robert Resch <robert@resch.dev>
edenhaus
requested changes
Jun 21, 2024
edenhaus
requested changes
Jun 26, 2024
| } | ||
| }, | ||
| "roborock": { | ||
| "description": "Configure setting options for all Roborock devices.", |
There was a problem hiding this comment.
Please update this file to match the latest code changes.
A lot can be removed
| """Test that the options flow works.""" | ||
| result = await hass.config_entries.options.async_init(setup_entry.entry_id) | ||
|
|
||
| # result = await hass.config_entries.options.async_configure( |
There was a problem hiding this comment.
Please remove comment out code
Co-authored-by: Robert Resch <robert@resch.dev>
edenhaus
requested changes
Jun 26, 2024
edenhaus
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
With the introduction of maps into core, there are a lot of things the users can configure. If I need to split up this PR I can, but I figured it made sense to include them all together as otherwise each PR would take refactoring to include the menus how I would like.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: