Integration is not starting if you have shared robots in your account

[gvillo]

The problem

The issue appears after my dad shared his Roborock with my account and this integration is trying to reach locally his robot and it crashes (I'm not on that network and there is no response). And I couldn't test if the device is offline (like I have another Roborock in a summer house that's turned off when no one is there) if this integration fails too -but I assume that it fails too-.

I would say a good solution for this is to be able to select which device you want to add to HA, because now it's trying to add 3 devices, which just one is on my house. The other two devices are just shared devices with me.

What version of Home Assistant Core has the issue?

core-2023.9.0

What was the last working version of Home Assistant Core?

core-2023.8.2

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roborock

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roborock

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2023-09-06 17:57:26.321 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry ga********do@gmail.com for roborock
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/roborock/__init__.py", line 45, in async_setup_entry
    network_results = await asyncio.gather(
                      ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 489, in get_networking
    return await self.send_command(RoborockCommand.GET_NETWORK_INFO, return_type=NetworkInfo)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 389, in send_command
    response = await self._send_command(method, params)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roborock/cloud_api.py", line 207, in _send_command
    return await self.send_message(roborock_message)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roborock/cloud_api.py", line 185, in send_message
    (response, err) = await async_response
                      ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 321, in _wait_response
    raise RoborockTimeout(f"id={request_id} Timeout after {QUEUE_TIMEOUT} seconds") from None
roborock.exceptions.RoborockTimeout: id=10630 Timeout after 4 seconds

Additional information

No response

[home-assistant]

Hey there @humbertogontijo, @Lash-L, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign roborock Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

roborock documentation
roborock source
_{^{(message by IssueLinks)}}

[biscuitee]

I am having the same issue since 2023.8.3 . I have 1 roborock and 1 shared roborock linked to my roborock account. It works well in HA 2023.8.2 and before, but failed to load after upgrading to 2023.8.3.

[Lash-L]

If anyone is willing to share a robot with me - I can take a look into this. As it should be working. Your shred vacuum should connect with the online version of our code

[gvillo]

If anyone is willing to share a robot with me - I can take a look into this. As it should be working. Your shred vacuum should connect with the online version of our code

the problem of sharing a device is there is no option in Roborock app to remove access unfortunately. You can use your own Roborock account and have a home-assistant in different network (VPN connected or guest network), it's the same result, the integration will try to reach your robot using the private IP and it'll crash in the same way (timeout bc IP address is unreachable).

If you want to have a shared robot you can create a 2nd Roborock account (must be in the same region otherwise it'll say account doesn't exist) and share yours with that account and try it.

[Lash-L]

I've tried:

1. Connecting with my account using a personal hotspot and not the same wifi - it successfully connects using the online api
2. Creating a new account, sharing my vacuum with this new account, and then connecting to that account - still not on my wifi and I connect successfully with the online api.

Besides - at this point of the code, it is not trying to communicate with your device locally. It is using the cloud api to get the network information, but it fails, which should not be the case if you are able to communicate with it through the app.

[gvillo]

One of my shared devices is offline certainly. I have 3 robots on my account, 2 online (1 shared), one offline (shared).

Yes, I am able to use the robots using the Roborock app without any issues

[Lash-L]

Well if the device is offline that would explain it

I have a PR already to better address errors during the initialization phase

#97311

[gvillo]

Awesome, yeah I explained that I have one device offline in a summer house, but I didn't point it out, sorry about that!

[gvillo]

I have the 3 vacuums online now and I am getting a bunch of entities, but no vacuum.##### entity so I cannot control it (or even use the vacuum card).

Seeing this on the logs:

roborock.cloud_api] [Perlita] id=##### Requesting method get_flow_led_status with [] 2023-09-10 20:56:08.154 DEBUG (MainThread) [roborock.cloud_api] [Perlita] Sending PUBLISH (d0, q0, r0, m27), 'b'rr/m/i/YYYYYYYYYYY/XXXXXXXXXXXX'', properties=None, ... (215 bytes) 2023-09-10 20:56:08.156 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 495, in async_add_entities tasks = [ ^ File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 495, in tasks = [ ^ File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 64, in RoborockVacuum(slugify(device_id), coordinator) File "/usr/src/homeassistant/homeassistant/components/roborock/vacuum.py", line 96, in __init__ self._attr_fan_speed_list = self._device_status.fan_power.keys() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'keys' 2023-09-10 20:56:08.164 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 495, in async_add_entities tasks = [ ^ File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 495, in tasks = [ ^ File "/usr/src/homeassistant/homeassistant/components/roborock/sensor.py", line 157, in if description.value_fn(coordinator.roborock_device_info.props) is not None ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/roborock/sensor.py", line 126, in value_fn=lambda data: data.status.error_code.name, ^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'name' 2023-09-10 20:56:08.178 WARNING (MainThread) [homeassistant.helpers.entity] Entity None (<class 'homeassistant.components.roborock.time.RoborockTimeEntity'>) is implicitly using device name by not setting its name. Instead, the name should be set to None, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+roborock%22

I've obfuscated the url just in case. It's using the cloud, that 'Perlita' robot is not on my network. That Robot is a Roborock S7 Max Ultra (not MaxV)

[biscuitee]

Hi, the roborock integration is actually working with my account having both a physical vacuum and a shared vacuum prior to HA 2023.8.3 I am not sure what has changed but now my integration is unable to load with the error as above shared.

[jellewie]

I can comfirm somethings

1. I didn't had by roborock shared (S5max and S7) and everything worked.
2. I shared my bots (just pending) and it broke
3. I removed the integration, and re-added it, no lock no bots detected/added at all.
4. I unshared one of them, still the same problem.
5. I also removed the other pending share invite. And the integration picked up both bots again.

It seems that if you have shared (even pending) one or more roborocks. This integration breaks.

Im running HA on a PI4 4GB Supervisor 2023.09.2 Operating System 10.5
I do not seem to know where to find the integration version rumber of roborock, but at the time of writing there are no updates for me.
roborock.vacuum.s5e Firmware: 02.16.62
roborock.vacuum.a15 Firmware: 02.16.12