Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IRSAP Now Integration #5910

Closed
wants to merge 8 commits into from
Closed

Add IRSAP Now Integration #5910

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91a25ab
Add files via upload
Sim0cYz Sep 26, 2024
df06121
Merge branch 'master' into master
Sim0cYz Sep 29, 2024
06a0014
Merge branch 'home-assistant:master' into master
Sim0cYz Sep 30, 2024
cf1ba46
Delete custom_integrations/irsap_ha directory
Sim0cYz Sep 30, 2024
abc13af
Add files via upload
Sim0cYz Sep 30, 2024
90b1ac9
Correct folder name
Sim0cYz Sep 30, 2024
4e37474
changed folder name
Sim0cYz Sep 30, 2024
d7a19ee
Merge branch 'master' into master
Sim0cYz Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. Please revert this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frenck, sorry for the insistence but I wanted to know if you had had time to look and let me know if there is anything else to fix on our side or if everything is ready for the release of the icon. So even with HACS we are ready to be published =)

Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valerix85 This is not waiting on me. This PR is in draft, meaning: It is not ready for review. The author can mark it ready for review when they have processed all comments (including this one, as this unrelated change is still in the PR).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @frenck it was a misunderstanding with @Sim0cYz that now has resolved. I think we’re good to go 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not, this comment hasn't been resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will guide @Sim0cYz to resolve it. Many thanks and sorry to bother you again 😊

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this file needs to be removed.

I've requested multiple times now to resolve this comment and it isn't happening.

I'm going to close this PR for now for that reason.

../Frenck

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frenck ,
I understand the frustration there is in these cases but @Sim0cYz not being practical didn't understand, I got added to his fork and fixed it.
Please bear with me and reopen so we can get the logo.
If there is anything else, please write to me so I don't prolong it more than necessary and don't take more of your time.

Thank you again for your help

"githubPullRequests.ignoredPullRequestBranches": [
"master"
]
}
Binary file added custom_integrations/irsap-ha/dark_icon.png
View file
Open in desktop
frenck marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/dark_icon@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/dark_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/dark_logo@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/icon@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added custom_integrations/irsap-ha/logo@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.