-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRSAP Now Integration #5910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @frenck , I talked with the other guys and we decided to keep |
Hi @frenck here is one of the developers writing, we have released in the “main” branch the very first version so we are affixed with what is required. Thanks for your time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unrelated change. Please revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @frenck, sorry for the insistence but I wanted to know if you had had time to look and let me know if there is anything else to fix on our side or if everything is ready for the release of the icon. So even with HACS we are ready to be published =)
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valerix85 This is not waiting on me. This PR is in draft, meaning: It is not ready for review. The author can mark it ready for review when they have processed all comments (including this one, as this unrelated change is still in the PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not, this comment hasn't been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will guide @Sim0cYz to resolve it. Many thanks and sorry to bother you again 😊
meanwhile, I changed the folder name (now it's irsap_ha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the open comment.
../Frenck
done! |
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this file needs to be removed.
I've requested multiple times now to resolve this comment and it isn't happening.
I'm going to close this PR for now for that reason.
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @frenck ,
I understand the frustration there is in these cases but @Sim0cYz not being practical didn't understand, I got added to his fork and fixed it.
Please bear with me and reopen so we can get the logo.
If there is anything else, please write to me so I don't prolong it more than necessary and don't take more of your time.
Thank you again for your help
Proposed change
Icons and logo for the IRSAP Now heaters custom integration.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)