Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRSAP Now Integration #5910

Closed
wants to merge 8 commits into from
Closed

Conversation

Sim0cYz
Copy link
Contributor

@Sim0cYz Sim0cYz commented Sep 26, 2024

Proposed change

Icons and logo for the IRSAP Now heaters custom integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/hexCut/irsap-ha

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domain of the integration in the linked repository doesn't match the domain used in this PR and doesn't match the integration folder name upstream.

CleanShot 2024-09-30 at 08 19 53@2x

Please ensure the domains match.

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 30, 2024 06:20
@Sim0cYz Sim0cYz requested a review from frenck September 30, 2024 09:00
@Sim0cYz
Copy link
Contributor Author

Sim0cYz commented Sep 30, 2024

Hi @frenck , I talked with the other guys and we decided to keep irsap-ha as domain.
It will match in the custom component repository in the few hours. Thank you!

@valerix85
Copy link
Contributor

Hi @frenck here is one of the developers writing, we have released in the “main” branch the very first version so we are affixed with what is required.
If anything else is needed we are here to help.

Thanks for your time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. Please revert this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frenck, sorry for the insistence but I wanted to know if you had had time to look and let me know if there is anything else to fix on our side or if everything is ready for the release of the icon. So even with HACS we are ready to be published =)

Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valerix85 This is not waiting on me. This PR is in draft, meaning: It is not ready for review. The author can mark it ready for review when they have processed all comments (including this one, as this unrelated change is still in the PR).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @frenck it was a misunderstanding with @Sim0cYz that now has resolved. I think we’re good to go 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not, this comment hasn't been resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will guide @Sim0cYz to resolve it. Many thanks and sorry to bother you again 😊

custom_integrations/irsap-ha/dark_icon.png Outdated Show resolved Hide resolved
@Sim0cYz
Copy link
Contributor Author

Sim0cYz commented Sep 30, 2024

meanwhile, I changed the folder name (now it's irsap_ha)

@Sim0cYz Sim0cYz requested a review from frenck October 1, 2024 07:50
@Sim0cYz Sim0cYz marked this pull request as ready for review October 9, 2024 20:13
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the open comment.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft October 10, 2024 08:09
@Sim0cYz Sim0cYz marked this pull request as ready for review October 25, 2024 11:22
@home-assistant home-assistant bot requested a review from frenck October 25, 2024 11:22
@techunleadit
Copy link

Please resolve the open comment.

../Frenck

done!

@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this file needs to be removed.

I've requested multiple times now to resolve this comment and it isn't happening.

I'm going to close this PR for now for that reason.

../Frenck

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frenck ,
I understand the frustration there is in these cases but @Sim0cYz not being practical didn't understand, I got added to his fork and fixed it.
Please bear with me and reopen so we can get the logo.
If there is anything else, please write to me so I don't prolong it more than necessary and don't take more of your time.

Thank you again for your help

@frenck frenck closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants