-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EufyLife logo #4039
Add EufyLife logo #4039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons provided seems to be application icons from their apps?
Please use the eufy branding instead.
Please note, the use of more specific product branding is allowed, but that would only be accepted if a brand definition in the Core repository is made under which this integration would be put.
../Frenck
@frenck I was actually planning to create a brand definition in core, since there will be two Eufy integrations. The existing |
Great, but this PR and the core PR don't reflect that.
Can be done in these PRs directly. ../Frenck |
@frenck OK, I updated this PR and the core PR to add the eufy brand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core_integrations/eufy
folder can be symlinked to the brands one
@frenck If I did that, then the |
To clarify the above statement, the current icon used by the |
Thanks, that is clear! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdr99 👍
../Frenck
Proposed change
Add logo for the proposed EufyLife integration.
Also add logo and icon for eufy brand.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)