-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EufyLife Bluetooth integration #85907
Conversation
I'll try to give this a second pass tomorrow after some sleep. I still need to look through the lib as well |
@bdraco Sounds good, thanks for all of your feedback so far! |
Updated this PR to add a brand for eufy, as suggested in home-assistant/brands#4039 (comment). |
I think this is just about ready to merge. I found a few small presentation issues that need to be sorted out first |
Thanks @bdr99 |
History stats tests are failing with
|
@bdraco Do you think the test failures are related to this PR? |
Fixes test failures seen here: home-assistant#86048 (comment) home-assistant#85907 (comment)
alternate to home-assistant#86051 Fixes test failures seen here: home-assistant#86048 (comment) home-assistant#85907 (comment)
Co-authored-by: J. Nick Koston <nick@koston.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR. Thanks!
discovery_info = self._discovery_info | ||
|
||
model_name = MODEL_TO_NAME.get(discovery_info.name) | ||
assert model_name is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using dict.get
on line 50 if we know that they key is not missing?
return True | ||
|
||
@property | ||
def native_value(self) -> float | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use self._attr_native_value
instead in _handle_state_update
and async_added_to_hass
to set the native value.
Proposed change
Add a new integration for EufyLife Bluetooth smart scale devices.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: