Install TopcomInterface for ci tests #547
Conversation
|
Please cherry-pick the commit from #546 so we see if the tests actually pass. |
Good point. Done. |
Codecov ReportBase: 70.50% // Head: 70.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 70.50% 70.48% -0.02%
==========================================
Files 435 435
Lines 71987 71987
==========================================
- Hits 50754 50742 -12
- Misses 21233 21245 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Interesting, I didn't expect the tests to succeed because Arch currently has the same version of topcom as the one you download: https://archlinux.org/packages/community/x86_64/topcom/. So maybe it has something to do with the build flags. In any case: Nice that it works now :-) |
|
Wonderful Martin, thank you very much. |
An attempt at building the
TopcomInterfacefor the ci-tests of thehomalg_project,so that a fixed version oftopcomis being used (cf. homalg-project/ToricVarieties_project#200). The idea is that the installer of theTopcomInterfacedownloads and builds the version inside the folder of theTopcomInterfacepackage. Ideally, the package should then find and use this very version oftopcom(rather than e.g. the system version).Note that this could be easily extended to the entire
ToricVarieties_projectby executingmake installin the root folder of theToricVarieties_project. I have not done this here, as it requires more build time. If this is desirable and you want to execute all tests of theToricVarieties_project, this is how it could be initiated.