Tests fail with TOPCOM 1.1.1

[zickgraf]

With TOPCOM 1.1.1 the following errors occur when executing make test in ToricVarieties:

 ┌───────┐   GAP 4.12.0 of 2022-08-18
 │  GAP  │   https://www.gap-system.org/
 └───────┘   Architecture: x86_64-pc-linux-gnu-default64-kv8
 Configuration:  gmp 6.2.1, GASMAN
 Loading the library and packages ...

 Packages:   AClib 1.3.2, Alnuth 3.2.1, AtlasRep 2.1.4, AutoDoc 2022.07.10, 
             AutPGrp 1.11, Browse 1.8.14, CRISP 1.4.5, Cryst 4.1.25, 
             CrystCat 1.1.10, CTblLib 1.3.4, FactInt 1.6.3, FGA 1.4.0, 
             Forms 1.2.8, GAPDoc 1.6.6, genss 1.6.7, IO 4.7.2, IRREDSOL 1.4.3, 
             LAGUNA 3.9.5, orb 4.8.5, Polenta 1.3.10, Polycyclic 2.16, 
             PrimGrp 3.4.2, RadiRoot 2.9, recog 1.3.2, ResClasses 4.7.3, 
             SmallGrp 1.5, Sophus 1.27, SpinSym 1.5.2, TomLib 1.2.9, 
             TransGrp 3.6.3, utils 0.76
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
Architecture: x86_64-pc-linux-gnu-default64-kv8

testing: /var/lib/jenkins/workspace/lg-project_homalg_project_master/pkg/Toric\
Varieties_project/ToricVarieties//tst/000_LoadPackage.tst
    1610 ms (194 ms GC) and 169MB allocated for 000_LoadPackage.tst
testing: /var/lib/jenkins/workspace/lg-project_homalg_project_master/pkg/Toric\
Varieties_project/ToricVarieties//tst/toricvarieties01.tst
Evaluating Commandline Options ...
Evaluating Commandline Options ...
########> Diff in /var/lib/jenkins/workspace/lg-project_homalg_project_ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
81
# Input is:
H5_version2 := DeriveToricVarietiesFromGrading( [[0,1,1,0],[1,0,-5,1]], false \
);
# Expected output:
[ <A toric variety of dimension 2> ]
# But found:
Error, Variable: 'unknown' must have a value
Syntax error: ] expected in stream:1
_EVALSTRINGTMP:=[unknown option --regular  - exiting];
                         ^^^^^^
Error, Could not evaluate string.

########
########> Diff in /var/lib/jenkins/workspace/lg-project_homalg_project_ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
83
# Input is:
H5_version3 := ToricVarietyFromGrading( [[0,1,1,0],[1,0,-5,1]] );
# Expected output:
<A toric variety of dimension 2>
# But found:
Error, Variable: 'unknown' must have a value
Syntax error: ] expected in stream:1
_EVALSTRINGTMP:=[unknown option --regular  - exiting];
                         ^^^^^^
Error, Could not evaluate string.

########

The last working version was 0.17.10. (I have downgraded TOPCOM in our CI for now, but will disable the tests the next time TOPCOM is updated automatically, which happens once a week.)

[HereAround]

@zickgraf For the latest topcom version, command line arguments must be passed as streams. This was different in the older version and the cause as to why this does not work any more.

My installer for the topcom_interface has a hard coded version number, so that it would download a version of topcom with which the interface works. This is my humble attempt to avoid errors such as the above.

The installer in the ToricVarieties_project was using the version with which the tests completed successfully in the past. Since the tests failed out of a sudden, something else must have changed. Maybe the once supported topcom version received changes?

Either way, I have spend a couple of hours on this today (cf. #201). The interface now works with topcom 1.1.2. No warranty (actually - no warranty whatsoever) for never versions.

Once the above PR passes all tests and is merged, you should be able to reactive all tests.

[HereAround]

Closed automatically by github - feel free to reopen if needed. Otherwise I consider this fixed.

[zickgraf]

There are still errors in our CI:

testing: /var/lib/jenkins/workspace/homalg_project_revert-531-master/pkg/Toric\
Varieties_project/ToricVarieties//tst/000_LoadPackage.tst
    1367 ms (174 ms GC) and 170MB allocated for 000_LoadPackage.tst
testing: /var/lib/jenkins/workspace/homalg_project_revert-531-master/pkg/Toric\
Varieties_project/ToricVarieties//tst/toricvarieties01.tst
########> Diff in /var/lib/jenkins/workspace/homalg_project_revert-531-ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
81
# Input is:
H5_version2 := DeriveToricVarietiesFromGrading( [[0,1,1,0],[1,0,-5,1]], false \
);
# Expected output:
[ <A toric variety of dimension 2> ]
# But found:
Error, first argument must be a filename or output stream
########
########> Diff in /var/lib/jenkins/workspace/homalg_project_revert-531-ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
83
# Input is:
H5_version3 := ToricVarietyFromGrading( [[0,1,1,0],[1,0,-5,1]] );
# Expected output:
<A toric variety of dimension 2>
# But found:
Error, first argument must be a filename or output stream
########

[zickgraf]

The installer in the ToricVarieties_project was using the version with which the tests completed successfully in the past. Since the tests failed out of a sudden, something else must have changed. Maybe the once supported topcom version received changes?

In our CI, the system topcom is used and was updated by Arch some weeks ago. If you want to make sure that a fixed version is used, please create a PR to prepare the environment in https://github.com/homalg-project/homalg_project/blob/master/ci_prepare.

[HereAround]

There are still errors in our CI:

testing: /var/lib/jenkins/workspace/homalg_project_revert-531-master/pkg/Toric\
Varieties_project/ToricVarieties//tst/000_LoadPackage.tst
    1367 ms (174 ms GC) and 170MB allocated for 000_LoadPackage.tst
testing: /var/lib/jenkins/workspace/homalg_project_revert-531-master/pkg/Toric\
Varieties_project/ToricVarieties//tst/toricvarieties01.tst
########> Diff in /var/lib/jenkins/workspace/homalg_project_revert-531-ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
81
# Input is:
H5_version2 := DeriveToricVarietiesFromGrading( [[0,1,1,0],[1,0,-5,1]], false \
);
# Expected output:
[ <A toric variety of dimension 2> ]
# But found:
Error, first argument must be a filename or output stream
########
########> Diff in /var/lib/jenkins/workspace/homalg_project_revert-531-ma\
ster/pkg/ToricVarieties_project/ToricVarieties//tst/toricvarieties01.tst:
83
# Input is:
H5_version3 := ToricVarietyFromGrading( [[0,1,1,0],[1,0,-5,1]] );
# Expected output:
<A toric variety of dimension 2>
# But found:
Error, first argument must be a filename or output stream
########

This is again an issue with the output that topcom provides. Thus indicates a different version. So...

The installer in the ToricVarieties_project was using the version with which the tests completed successfully in the past. Since the tests failed out of a sudden, something else must have changed. Maybe the once supported topcom version received changes?

In our CI, the system topcom is used and was updated by Arch some weeks ago. If you want to make sure that a fixed version is used, please create a PR to prepare the environment in https://github.com/homalg-project/homalg_project/blob/master/ci_prepare.

Here is an attempt at that: homalg-project/homalg_project#547. Let us see if this works.