Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not extend the range of the hom-structure by identity twice #1457

Merged
merged 1 commit into from
Sep 12, 2023
Merged

do not extend the range of the hom-structure by identity twice #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CAP/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "CAP",
Subtitle := "Categories, Algorithms, Programming",
Version := "2023.09-01",
Version := "2023.09-02",
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
License := "GPL-2.0-or-later",

Expand Down
7 changes: 7 additions & 0 deletions CAP/gap/CategoryMorphisms.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,11 @@
function ( C )
local object_function, morphism_function, object_function_inverse, morphism_function_inverse;

if IsBound( C!.range_category_of_hom_structure_already_extended_by_identity ) then
## the range of the hom-structure has already been extended by identity
return;

Check warning on line 841 in CAP/gap/CategoryMorphisms.gi

View check run for this annotation

Codecov / codecov/patch

CAP/gap/CategoryMorphisms.gi#L841 

Added line #L841 was not covered by tests
fi;

object_function := function ( category, range_category, object )
#% CAP_JIT_RESOLVE_FUNCTION

Expand Down Expand Up @@ -866,6 +871,8 @@

ExtendRangeOfHomomorphismStructureByFullEmbedding( C, RangeCategoryOfHomomorphismStructure( C ), object_function, morphism_function, object_function_inverse, morphism_function_inverse );

C!.range_category_of_hom_structure_already_extended_by_identity := true;

end );

######################################
Expand Down