Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not extend the range of the hom-structure by identity twice #1457

Conversation

mohamed-barakat
Copy link
Member

No description provided.

@mohamed-barakat mohamed-barakat force-pushed the ExtendRangeOfHomomorphismStructureByIdentityAsFullEmbedding branch from 2e806fc to 2392e91 Compare September 12, 2023 10:48
@mohamed-barakat
Copy link
Member Author

I would like to discuss the potential risks of such a change.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 80.00% of modified lines.

Files Changed Coverage
CAP/gap/CategoryMorphisms.gi 75.00%
CAP/PackageInfo.g 100.00%

📢 Thoughts on this report? Let us know!.

@zickgraf
Copy link
Member

I do not see a risk, but it only prevents your error in a very specific situation, i.e.

gap> WrapperCategory( SkeletalFinSets, rec( ) );
gap> WrapperCategory( SkeletalFinSets, rec( ) );

should still throw an error with the PR if I am not mistaken.

If you still want to merge this, please rename the component to a more descriptive name.

@mohamed-barakat mohamed-barakat force-pushed the ExtendRangeOfHomomorphismStructureByIdentityAsFullEmbedding branch from 2392e91 to 5de4d90 Compare September 12, 2023 12:36
@mohamed-barakat
Copy link
Member Author

I do not see a risk, but it only prevents your error in a very specific situation, i.e.

gap> WrapperCategory( SkeletalFinSets, rec( ) );
gap> WrapperCategory( SkeletalFinSets, rec( ) );

should still throw an error with the PR if I am not mistaken.

Yes, it does. For it to work I would have to take care of the if-case in ReinterpretationOfCategory.gi, which I currently do not need. I wanted the change to be minimal.

If you still want to merge this, please rename the component to a more descriptive name.

Done.

@mohamed-barakat mohamed-barakat merged commit ae71c5b into homalg-project:master Sep 12, 2023
2 of 4 checks passed
@mohamed-barakat mohamed-barakat deleted the ExtendRangeOfHomomorphismStructureByIdentityAsFullEmbedding branch September 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants