Refactor Graph types for extensibility #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable at a glance... |
|
Ready to review and merge. |
jlstevens
reviewed
Jan 4, 2018
holoviews/element/graphs.py
Outdated
| @@ -98,6 +119,10 @@ class Graph(Dataset, Element2D): | |||
| kdims = param.List(default=[Dimension('start'), Dimension('end')], | |||
| bounds=(2, 2)) | |||
|
|
|||
| _node_type = Nodes | |||
|
|
|||
| _edge_type = EdgePaths | |||
There was a problem hiding this comment.
Wondering if this really needs to be private. It might be useful information for users in general though only advanced users should try setting it...
|
Looks like a sensible generalization though I would consider using |
|
No objection, I've pushed the change. |
|
Looks good, happy to merge when the tests are green. |
|
Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small amount of refactoring for
Graphcode to make it easier for extension libraries to subclass and extendGraphelements. In particular GeoViews will offer Graph and TriMesh elements and these changes are required to make that work.