Add projection aware Graph and TriMesh elements #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
philippjfr
commented
Jan 4, 2018
geoviews/operation.py
Outdated
| nodes = project_points(element.nodes, projection=self.projection) | ||
| data = (element.data, nodes) | ||
| if element._edgepaths: | ||
| data = data + (project_path(element.edgepaths),) |
There was a problem hiding this comment.
Forgot passing the projection here.
|
Almost ready, needs pyflakes fixes, need to define style/plot options for the new elements and one small fix I noted above. Also would be good to merge holoviz/holoviews#2240 first. |
|
The HoloViews PR is now merged and this is working as expected. Will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for projection aware
Graphelements to GeoViews including the basicGraphelement and theTriMeshelement. It relies on holoviz/holoviews#2240 to work correctly.