Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Docs on and Fix Extensions on OverviewLayer #565

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Clarify Docs on and Fix Extensions on OverviewLayer #565

merged 6 commits into from
Nov 13, 2023

Conversation

ilan-gold
Copy link
Collaborator

@ilan-gold ilan-gold commented Jan 18, 2022 •
edited
Loading

Background

Addresses #533 (comment)

Change List

  • Add a default extension prop for OverviewLayer

Checklist

  • Update JSdoc types if there is any API change.
  • Make sure Avivator works as expected with your change.

@ilan-gold
Copy link
Collaborator Author

cc @andreasg123 Feel free to clarify the docs.

@manzt manzt force-pushed the master branch 2 times, most recently from a503cb0 to 67a7f04 Compare August 8, 2022 20:13
@manzt
Copy link
Member

manzt commented Nov 12, 2023

Can this be merged?

@ilan-gold
Copy link
Collaborator Author

Well not without resolving the merge conflicts.

@ilan-gold
Copy link
Collaborator Author

But yes, otherwise

@manzt manzt merged commit aa43a4c into master Nov 13, 2023
5 checks passed
@manzt manzt deleted the ig/clarify_extensions branch November 13, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilan-gold @manzt