generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Release: Costco Figo promotion to Main #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* merge stage into main * changed links decoration approach
# Conflicts: # blocks/footer/footer.js # blocks/header/header.js # scripts/scripts.js
* Add svg icons * Fix svg icon name * Fix svg icon * Fix svg icon * Added gray column * Added autocomplite functionality * Added fix for autocomplite functionality * Added validagtors for promocode and zipcode, added loader animation * Added some validators * Added some validators * Handlers/validators refactoring * enhanced for Canada * Canadian legal and Canadian icons * the beginning of the submit execution * the middle of the submit execution * the completion of the submit execution * fix JavaScript linting * Fix validators for subbmit button * allow for re-entering Step 1 * Fix validators for breed input * honor a query param of 'petId' when re-entering Step 1 * strengthen our client API * Fix validators for zipCode and async problem * Separate js for the first page * Fix zip code handler * Some part of summary-quote * Added button "Proceed to Payment" * Small css fixes * Small fixes for lpm-plus * Fixed svg classes and added the icon for lpm-plus * Added fragments with additional info to summary page * Added loader.js * Small refctoring * Move the form to form.js * Added the form to summary page * Remove wrong div * Fixed icons in fragments * Small cleaning * Form cleaning * Improved the chip number validator * Added isSummaryPage * Added isSummaryPage * Improve loader * Added loader to summary page * Added isSummaryPage to the form * Intermediate code for adding a pet on the summary page * Fix issue with styled icons * Added form functionality to summary page * Added pet removing functionality to summary page * Hide promocode field on summary page * Fix flow id * Fix css * Fix css * Fixes for CA * Fixes for linters * Added promo code functionality * Fixed parameter for payment url * Fix promo code functionality * Fix typo * Fix styles * Added header with only logo * Fix styles * Improvments for zip code handler * WIP on feature/post-purchase-thank-you-page * Fix zip code handler for CA * Promocode fixes * Promocode fixes * WIP on feature/post-purchase-thank-you-page * Added minus for discount * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * Remove a comment * Fixed birthday for pets * WIP on feature/post-purchase-thank-you-page * Fixed birthday for pets * Fixed birthday for pets --------- Co-authored-by: Bohdan Korablov <korablov@adobe.com> Co-authored-by: Mike Weis <miweis@magento.com> Co-authored-by: Mike Weis <miweis@adobe.com>
…203) * Add svg icons * Fix svg icon name * Fix svg icon * Fix svg icon * Added gray column * Added autocomplite functionality * Added fix for autocomplite functionality * Added validagtors for promocode and zipcode, added loader animation * Added some validators * Added some validators * Handlers/validators refactoring * enhanced for Canada * Canadian legal and Canadian icons * the beginning of the submit execution * the middle of the submit execution * the completion of the submit execution * fix JavaScript linting * Fix validators for subbmit button * allow for re-entering Step 1 * Fix validators for breed input * honor a query param of 'petId' when re-entering Step 1 * strengthen our client API * Fix validators for zipCode and async problem * Separate js for the first page * Fix zip code handler * Some part of summary-quote * Added button "Proceed to Payment" * Small css fixes * Small fixes for lpm-plus * Fixed svg classes and added the icon for lpm-plus * Added fragments with additional info to summary page * Added loader.js * Small refctoring * Move the form to form.js * Added the form to summary page * Remove wrong div * Fixed icons in fragments * Small cleaning * Form cleaning * Improved the chip number validator * Added isSummaryPage * Added isSummaryPage * Improve loader * Added loader to summary page * Added isSummaryPage to the form * Intermediate code for adding a pet on the summary page * Fix issue with styled icons * Added form functionality to summary page * Added pet removing functionality to summary page * Hide promocode field on summary page * Fix flow id * Fix css * Fix css * Fixes for CA * Fixes for linters * Added promo code functionality * Fixed parameter for payment url * Fix promo code functionality * Fix typo * Fix styles * Added header with only logo * Fix styles * Improvments for zip code handler * WIP on feature/post-purchase-thank-you-page * Fix zip code handler for CA * Promocode fixes * Promocode fixes * WIP on feature/post-purchase-thank-you-page * Added minus for discount * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * Remove a comment * Fixed birthday for pets * WIP on feature/post-purchase-thank-you-page * Fixed birthday for pets * Fixed birthday for pets * QA feedback updates * Fix lint issue --------- Co-authored-by: Bohdan Korablov <korablov@adobe.com> Co-authored-by: Mike Weis <miweis@magento.com> Co-authored-by: Mike Weis <miweis@adobe.com>
…204) * Add svg icons * Fix svg icon name * Fix svg icon * Fix svg icon * Added gray column * Added autocomplite functionality * Added fix for autocomplite functionality * Added validagtors for promocode and zipcode, added loader animation * Added some validators * Added some validators * Handlers/validators refactoring * enhanced for Canada * Canadian legal and Canadian icons * the beginning of the submit execution * the middle of the submit execution * the completion of the submit execution * fix JavaScript linting * Fix validators for subbmit button * allow for re-entering Step 1 * Fix validators for breed input * honor a query param of 'petId' when re-entering Step 1 * strengthen our client API * Fix validators for zipCode and async problem * Separate js for the first page * Fix zip code handler * Some part of summary-quote * Added button "Proceed to Payment" * Small css fixes * Small fixes for lpm-plus * Fixed svg classes and added the icon for lpm-plus * Added fragments with additional info to summary page * Added loader.js * Small refctoring * Move the form to form.js * Added the form to summary page * Remove wrong div * Fixed icons in fragments * Small cleaning * Form cleaning * Improved the chip number validator * Added isSummaryPage * Added isSummaryPage * Improve loader * Added loader to summary page * Added isSummaryPage to the form * Intermediate code for adding a pet on the summary page * Fix issue with styled icons * Added form functionality to summary page * Added pet removing functionality to summary page * Hide promocode field on summary page * Fix flow id * Fix css * Fix css * Fixes for CA * Fixes for linters * Added promo code functionality * Fixed parameter for payment url * Fix promo code functionality * Fix typo * Fix styles * Added header with only logo * Fix styles * Improvments for zip code handler * WIP on feature/post-purchase-thank-you-page * Fix zip code handler for CA * Promocode fixes * Promocode fixes * WIP on feature/post-purchase-thank-you-page * Added minus for discount * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * Remove a comment * Fixed birthday for pets * WIP on feature/post-purchase-thank-you-page * Fixed birthday for pets * Fixed birthday for pets * QA feedback updates * Fix lint issue * QA feedback updates --------- Co-authored-by: Bohdan Korablov <korablov@adobe.com> Co-authored-by: Mike Weis <miweis@magento.com> Co-authored-by: Mike Weis <miweis@adobe.com>
* Add svg icons * Fix svg icon name * Fix svg icon * Fix svg icon * Added gray column * Added autocomplite functionality * Added fix for autocomplite functionality * Added validagtors for promocode and zipcode, added loader animation * Added some validators * Added some validators * Handlers/validators refactoring * enhanced for Canada * Canadian legal and Canadian icons * the beginning of the submit execution * the middle of the submit execution * the completion of the submit execution * fix JavaScript linting * Fix validators for subbmit button * allow for re-entering Step 1 * Fix validators for breed input * honor a query param of 'petId' when re-entering Step 1 * strengthen our client API * Fix validators for zipCode and async problem * Separate js for the first page * Fix zip code handler * Some part of summary-quote * Added button "Proceed to Payment" * Small css fixes * Small fixes for lpm-plus * Fixed svg classes and added the icon for lpm-plus * Added fragments with additional info to summary page * Added loader.js * Small refctoring * Move the form to form.js * Added the form to summary page * Remove wrong div * Fixed icons in fragments * Small cleaning * Form cleaning * Improved the chip number validator * Added isSummaryPage * Added isSummaryPage * Improve loader * Added loader to summary page * Added isSummaryPage to the form * Intermediate code for adding a pet on the summary page * Fix issue with styled icons * Added form functionality to summary page * Added pet removing functionality to summary page * Hide promocode field on summary page * Fix flow id * Fix css * Fix css * Fixes for CA * Fixes for linters * Added promo code functionality * Fixed parameter for payment url * Fix promo code functionality * Fix typo * Fix styles * Added header with only logo * Fix styles * Improvments for zip code handler * WIP on feature/post-purchase-thank-you-page * Fix zip code handler for CA * Promocode fixes * Promocode fixes * WIP on feature/post-purchase-thank-you-page * Added minus for discount * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * WIP on feature/post-purchase-thank-you-page * Remove a comment * Fixed birthday for pets * WIP on feature/post-purchase-thank-you-page * Fixed birthday for pets * Fixed birthday for pets * QA feedback updates * Fix lint issue * QA feedback updates * QA feedback updates --------- Co-authored-by: Bohdan Korablov <korablov@adobe.com> Co-authored-by: Mike Weis <miweis@magento.com> Co-authored-by: Mike Weis <miweis@adobe.com>
* WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Fix lint issues on feature/membership-v2-paid-page
* WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Fix lint issues on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page
* WIP on feature/lost-pet-protection-paid-page * WIP on feature/lost-pet-protection-paid-page * WIP on feature/lost-pet-protection-paid-page * WIP on feature/lost-pet-protection-paid-page * WIP on feature/lost-pet-protection-paid-page
* WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * WIP on feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Datalayer updates for feature/membership-v2-paid-page * Fix lint issues on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page * QA feedback updates on feature/membership-v2-paid-page
* WIP on feature/lost-pet-recovery-paid-page * WIP on feature/lost-pet-recovery-paid-page * WIP on feature/lost-pet-recovery-paid-page * WIP on feature/lost-pet-recovery-paid-page * Fix lint issue
Merging main into develop
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-367: Updating subid value for costco figo
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing --------- Co-authored-by: hero-dokane <46008504+hero-dokane@users.noreply.github.com>
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing * PM-375: add additional css prop for safari to prevent user-select on disabled field --------- Co-authored-by: hero-dokane <46008504+hero-dokane@users.noreply.github.com>
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing * PM-375: add additional css prop for safari to prevent user-select on disabled field * PM-375: Added additional promo price comment key value used on conditional check --------- Co-authored-by: hero-dokane <46008504+hero-dokane@users.noreply.github.com>
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
hero-dokane
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
PM-375
Purpose / Changes
Under the epic PM-375 these changes are for all tasks related to the FE flow for a Costco Figo promotion
Validate Changes
See all validation requirements on each task under epic: https://pethealthinc.atlassian.net/browse/PM-375
Get poid (policy Id) from query string if page path is PET_PLANS_ANNUAL_URL (/annual-quote)
Validate the policy Id exists is Salesforce records and is eligible for promo based on eligibility criteria (via new proxy service)
If valid, request promo from assignNextAvailableCoupon API
IF a valid promo is returned, add to promo field and disable input.
IF multipet is false, on summary flow remove add a pet option and don't persist cart on return after abandoned cart
Before: https://main--24petwatch--hlxsites.hlx.page/lost-pet-protection/annual-quote
After: https://release-costco-figo-promotion--24petwatch--hlxsites.hlx.page/lost-pet-protection/annual-quote