Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync to Sprint Deploy 23: PM-652 Cart UI Overlap Issues #278

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Sync to Sprint Deploy 23: PM-652 Cart UI Overlap Issues #278

merged 6 commits into from
Nov 12, 2024

Conversation

hero-dokane
Copy link
Collaborator

Jira Ticket

PM-652

Purpose / Changes

Update CSS to fix elements overlapping on Step 1 of the Membership Form.

Validate Changes

Observe the form label / inputs for the microchip number and promo code to ensure there is no overlap.

@hero-dokane hero-dokane self-assigned this Nov 11, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 11, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 11, 2024 •
edited
Loading

Page Scores Audits Google
📱 /lost-pet-protection/lps-quote PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /lost-pet-protection/lps-quote Lighthouse returned error: Something went wrong. PSI

@aem-code-sync aem-code-sync bot temporarily deployed to bugfix/PM-652-cart-ui-overlap November 11, 2024 22:01 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bugfix/PM-652-cart-ui-overlap November 11, 2024 22:07 Inactive
pgilmore-phi
pgilmore-phi approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@pgilmore-phi pgilmore-phi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgilmore-phi pgilmore-phi merged commit 7259400 into release/sprint-23-deploy Nov 12, 2024
1 of 2 checks passed
pgilmore-phi pushed a commit that referenced this pull request Nov 13, 2024
@hero-dokane
Sync Release/Sprint 23 to Develop (#279)
6b9a875 
* WIP on bugfix/PM-637-ca-pet-tags

* PM-694 Updates to address css/js 404s (#277)

* Sync to Sprint Deploy 23: PM-652 Cart UI Overlap Issues (#278)

* PM-652: form ui updates

* PM-652: form ui updates

* Fix lint issue

* PM-652: form ui updates

* PM-652: form ui updates
pgilmore-phi pushed a commit that referenced this pull request Nov 13, 2024
@hero-dokane
Sync Release/Sprint 23 to Stage (#280)
58fc4fd 
* WIP on bugfix/PM-637-ca-pet-tags

* PM-694 Updates to address css/js 404s (#277)

* Sync to Sprint Deploy 23: PM-652 Cart UI Overlap Issues (#278)

* PM-652: form ui updates

* PM-652: form ui updates

* Fix lint issue

* PM-652: form ui updates

* PM-652: form ui updates
pgilmore-phi pushed a commit that referenced this pull request Nov 14, 2024
@hero-dokane
Sync Release/Sprint 23 to Main (#281)
bb6b074 
* WIP on bugfix/PM-637-ca-pet-tags

* PM-694 Updates to address css/js 404s (#277)

* Sync to Sprint Deploy 23: PM-652 Cart UI Overlap Issues (#278)

* PM-652: form ui updates

* PM-652: form ui updates

* Fix lint issue

* PM-652: form ui updates

* PM-652: form ui updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgilmore-phi pgilmore-phi pgilmore-phi approved these changes

Assignees

@hero-dokane hero-dokane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hero-dokane @pgilmore-phi